Fix bug in shadow handling on interfaces #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwrightcertinia
approved these changes
Sep 19, 2023
kjonescertinia
deleted the
108-stackoverflow-exception-after-download-fdn-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in shadow handling on interface that is triggered by the download FDN metadata. The fix is also on #155 but though better to split out as that PR is taking some time.
The problem here was we could end up with two interface methods each thinking it shadowed the other causing stack overflow in the unused analysis. The cause was the ordering we used to setup the shadow relationship which I have changed to ensure the interfaces are processed in the correct order.