Improve switch handling of brackets and integer/long #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwrightcertinia
approved these changes
Sep 6, 2023
kjonescertinia
deleted the
213-using-brackets-on-switch-when-expressions-that-are-expecting-literals-causes-an-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the handling of brackets around switch then literals, the parser has supported these for a while but apex-ls was broken if you tried to use them.
While working on that I noticed the handling of + & - before integer and long literals was broken. To fix this requires the change in apex-dev-tools/apex-parser#29 which allows for sequences of + & - before either integer or long literals. Only alternating sequences of + and - are supported, + can be treated as a no-op as can an even number of -. Where a long control value is used the when value may be an integer but the reverse is not supported even if the long value may fit in an int.