Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/ts 67 bug with issuing refund programmatically #19

Merged
merged 9 commits into from
Jun 22, 2022
Merged

Bug/ts 67 bug with issuing refund programmatically #19

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
46d3f2d
TS-67 [Woo-commerce] - refund bug when method is called with testendp…
javiercrac Jun 9, 2022
4c3daba
TS-67 [Woocommerce] - update readme file.
javiercrac Jun 9, 2022
5540a48
TS-67: [Wocommerce] For testing - all params can be sent
javiercrac Jun 9, 2022
04df182
update version to 1.2.3
javiercrac Jun 14, 2022
b3d5faf
Remove validations at endpoint. code review requested changes.
javiercrac Jun 15, 2022
2397701
TR-67: [WooCommerce]: refine test endpoint
apetrovici Jun 17, 2022
1d2951b
add validation for amount
javiercrac Jun 21, 2022
b75ac66
Code standar fix
javiercrac Jun 22, 2022
59f2210
Merge branch '1.2.3' into bug/TS-67-bug-with-issuing-refund-programma…
javiercrac Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Gateways/AbstractGateway.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,14 @@ public function process_refund( $order_id, $amount = null, $reason = '' ) {

$order = new WC_Order( $order_id );
$request = $this->prepare_request( $txn_type, $order );

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation looks good, but let's format it to respect the WooCommerce standards

if ( null != $amount ) {
$amount = str_replace(',', '.', $amount);
$amount = number_format((float)round($amount, 2, PHP_ROUND_HALF_UP), 2, '.', '');
if ( ! is_numeric($amount)) {
throw new Exception( __( 'Refund amount must be a valid number', 'globalpayments-gateway-provider-for-woocommerce' ) );
}
}
$request->set_request_data( array(
'refund_amount' => $amount,
'refund_reason' => $reason,
Expand Down