Markunknown sent with translateDoc interface #180
Conversation
assets/js/translator.js
Outdated
| $('div#docTranslation').fadeIn('fast'); | ||
| $('#detect, #srcLangSelect option[value=detect]').prop('disabled', true); | ||
| }); | ||
| $('#translateText > *:not(#translateOptionsContainer), #translateOptions > *:not(#markUnknownContainer') |
There was a problem hiding this comment.
I feel like this selector is missing a closing paren.
There was a problem hiding this comment.
Felt like I closed it with the paren outside. Added :D
|
This ends up looking really strange. The option should be in a similar position to where it is usually located. Maybe messing with |
|
@sushain97 , Um, would it make sense to simply add a CSS of |
Then it'll be too low when a file gets translated? |
|
@sushain97 , position set as required. Please have a look.
|
|
Why is it all the way at the bottom and not where it used to be?
… On Aug 10, 2017, at 11:12 AM, Monish Godhia ***@***.***> wrote:
@sushain97 <https://github.com/sushain97> , position set as required. Please have a look.
<https://user-images.githubusercontent.com/8894636/29177471-61de5984-7e0c-11e7-9f70-7dd4bf2d5ab5.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#180 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEBEfmnVxd4AreR9C5g6pHeqZxxRv6_Fks5sWx3ZgaJpZM4OqmGf>.
|
|
I am preserving its position wrt to the translation interface. Thus, I am adding a top margin equivalent to the height of |
|
I felt keeping it at the height where docTranslation ends would make more sense. Should I change it to that?
Yes. This is probably better.
… On Aug 10, 2017, at 11:40 AM, Monish Godhia ***@***.***> wrote:
I am preserving its position wrt to the translation interface. Thus, I am adding a top margin equivalent to the height of translatedText div. It looks very much at the bottom because of the relatively smaller height of docTranslation div and the absence of Instant Translation checkbox. What do you suggest its ideal height should be? I felt keeping it at the height where docTranslation ends would make more sense. Should I change it to that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#180 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEBEfqOipD_XTWFxicpB2Fp-DNSWZ1kjks5sWyR4gaJpZM4OqmGf>.
|
| $('#fileInput').show(); | ||
| $('div#fileName').hide(); | ||
| $('div#docTranslation').fadeIn('fast'); | ||
| $('#markUnknownContainer').css('margin-top', '200px'); |
There was a problem hiding this comment.
Hardcoding pixel values isn't a great approach. Is there any other method of handling this?
Fix #160