An experimental auto* re-wiring of libcheck-based testing (Duplicating Rietveld http://codereview.appspot.com/4833043/) #1
Conversation
Goals: * make libcheck-based testing optional (disabled by default, until tests are not expected to fail), enabled by --with-check and requiring detection of libcheck installation. * all tests (libcheck or other) are executed only during the "make check" (and "make distcheck", etc) phase * if libcheck is not specified and installed, other tests (such as simple shell-based scripts) should still be able to run during "make check" phase Implementation: * configure.ac is modified to require --with-check. If specified, pkg_config looks for libcheck. If found, AM-CONDITIONAL "CHECK" is set for use in tests/Makefile.am . "CHECK" replaces "TESTS", as "TESTS" is a reserved AM keyword for the testing phase(s). * tests/Makefile.am is modified to use the standard TESTS and check_* primaries and prefixes to enable testing. libcheck-based tests are enabled conditionally on "CHECK" from AC.
|
Quick (probably unrelated question), why is this diff massive and the one on Rietveld tiny? lack of distclean? or is it because these are 2 separate commits? |
|
@pames SIze of diff is related to the autoreconf artifacts. 4067653 represents the "real" change, and is what is shown on RIetveld. 58af3be is the auto* output caused by the changes in 4067653, and are not for human consumption or review. I omitted these from Rietveld, as Rietveld is not directly connected to commits, but was not able to omit this from GH as both commits should be applied together to maintain buildability. |
|
Gah, hit wrong button and "closed" request. @smaresca -- can you confirm behavior is (functionally) same as you intended in original version? |
|
@pames - do these modifications properly run your libcheck tests only when --with-check is supplied to ./configure, && when libcheck is installed, && only during issuance of "make check" ? |
|
LGTM Thanks for fixing the docs and that flag. |
Goals:
expected to fail), enabled by --with-check and requiring detection of libcheck
installation.
"make distcheck", etc) phase
shell-based scripts) should still be able to run during "make check" phase
Implementation:
looks for libcheck. If found, AM-CONDITIONAL "CHECK" is set for use in
tests/Makefile.am . "CHECK" replaces "TESTS", as "TESTS" is a reserved AM
keyword for the testing phase(s).
and prefixes to enable testing. libcheck-based tests are enabled conditionally
on "CHECK" from AC.