Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Cannot play video #15

Closed
fear-the-beaver opened this issue Jan 9, 2020 · 6 comments
Closed

Cannot play video #15

fear-the-beaver opened this issue Jan 9, 2020 · 6 comments
Assignees
@apcro

Comments

@fear-the-beaver
Copy link

fear-the-beaver commented Jan 9, 2020 •
edited
Loading

Steps:

  1. Allow to display videos in a gallery.
  2. Try to open a video file.

Expected:

  1. The app plays video.

Actual:

  1. Static fullscreen thumbnail is displayed.

ezgif com-resize

Workaround:

  1. Leaf can play the video when it opened via "Open with" button from the three dot menu.

Environment:

  1. App version 0.8.2.20 from Fdroid.
  2. Phone: oneplus 5t, OOS 9.0.10, android 9.
@endevdev
Copy link

endevdev commented Jan 9, 2020

I can confirm this issue and it's happening for gifs too

@apcro
Copy link
Owner

apcro commented Jan 10, 2020

I need to do more research on this, but it appears to be related to the 'play' button location and size - 'play' only responds properly if you tap in the exact center of the screen; tapping elsewhere just shows.hides the menu, acting like an image.

@apcro apcro self-assigned this Jan 10, 2020
@fear-the-beaver
Copy link
Author

I need to do more research on this, but it appears to be related to the 'play' button location and size - 'play' only responds properly if you tap in the exact center of the screen; tapping elsewhere just shows.hides the menu, acting like an image.

Can confirm, this works. But I've toggled instant play and still receive a preview with hidden play button instead.

@apcro
Copy link
Owner

apcro commented Feb 20, 2020

More information: This is related to the https://github.com/mikepenz/Android-Iconics library, used for icons in various places, not showing the Play icon properly.

@apcro
Copy link
Owner

apcro commented Feb 20, 2020

Further investigation shows this is related to the Theme library, not Iconics. Removing the internal call to the refreshTheme() override resolves the initial display issue.

@apcro
Copy link
Owner

apcro commented Feb 20, 2020

Extended: mikepenz/Android-Iconics#470 and mikepenz/Android-Iconics#480 are related.

@apcro apcro closed this as completed Feb 20, 2020
apcro added a commit that referenced this issue Feb 20, 2020
@apcro
Resolve #15
99c48f7
apcro added a commit that referenced this issue Feb 21, 2020
@apcro
v0.8.5
d081745 
==================
* Update library versions to latest
* Fix "Two identically-named options in the "open with" menu"
- #13
* Fix "Crash when clicking the changelog button"
- #14
* Fix "Cannot play video"
- #15
* Fix ""About" links inconsistent"
- #18
* Fix an issue with `content://` vs `file://` media types when selecting 'Open With'
- #20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@apcro apcro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apcro @fear-the-beaver @endevdev