reduce the number of mntr calls #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks like mntr command is sent for every 16 metrics being collected each time, instead send one call of mntr and fetch all the required metrics into a dictionary, process them and print on console/send it to ganglia
zhaxiancheng
pushed a commit
to zhaxiancheng/zookeeper
that referenced
this pull request
Sep 8, 2016
- Removed runBinaryScript
ztzg
pushed a commit
to ztzg/zookeeper
that referenced
this pull request
Nov 20, 2019
Minor fix to WriteLock class, and a quick hello.
huizhilu
added a commit
to huizhilu/zookeeper
that referenced
this pull request
Dec 15, 2020
The optimizes the paginated getChildren API to satisfy use cases better. The changes include: - On zk server, uses a formulate to pre-calculate the children's packet length when adding the children to the returning list, so the children packet is ensured within the jute.maxbuffer limit. - Adds an API getAllChildrenPaginated to fetch all children by leveraging the paginated getChildren API. - Optimize the sorting logic for paginated getChildren in DataTree: only when pagination is needed, children are sorted. 99% of the case for returning all children, the children could be returned in the 1st page. No need to sort them to avoid performance downgrade. - Returning a list of child name string for the API, instead of a list of PathWithStat - Add more tests to cover the new logic
huizhilu
added a commit
to huizhilu/zookeeper
that referenced
this pull request
Dec 22, 2020
The optimizes the paginated getChildren API to satisfy use cases better. The changes include: - On zk server, uses a formulate to pre-calculate the children's packet length when adding the children to the returning list, so the children packet is ensured within the jute.maxbuffer limit. - Adds an API getAllChildrenPaginated to fetch all children by leveraging the paginated getChildren API. - Optimize the sorting logic for paginated getChildren in DataTree: only when pagination is needed, children are sorted. 99% of the case for returning all children, the children could be returned in the 1st page. No need to sort them to avoid performance downgrade. - Returning a list of child name string for the API, instead of a list of PathWithStat - Add more tests to cover the new logic
mgao0
pushed a commit
to mgao0/zookeeper
that referenced
this pull request
Jan 25, 2022
The optimizes the paginated getChildren API to satisfy use cases better. The changes include: - On zk server, uses a formulate to pre-calculate the children's packet length when adding the children to the returning list, so the children packet is ensured within the jute.maxbuffer limit. - Adds an API getAllChildrenPaginated to fetch all children by leveraging the paginated getChildren API. - Optimize the sorting logic for paginated getChildren in DataTree: only when pagination is needed, children are sorted. 99% of the case for returning all children, the children could be returned in the 1st page. No need to sort them to avoid performance downgrade. - Returning a list of child name string for the API, instead of a list of PathWithStat - Add more tests to cover the new logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like mntr command is sent for every 16 metrics being collected each time, instead send one call of mntr and fetch all the required metrics into a dictionary, process them and print on console/send it to ganglia