ZOOKEEPER-3219: Fix flaky FileChangeWatcherTest #739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2018
|
@anmolnar can we merge this even though jenkins fails? It's failing with some completely unrelated error in the C test code :( |
|
+1 Thanks @ivmaykov! I’ll merge it tomorrow if there is no other comments. |
lvfangmin
approved these changes
Dec 19, 2018
|
retest this please |
|
@anmolnar I have tried many times but it keeps failing with completely unrelated errors (failures in the C test code, which this commit does not touch). |
|
Have merged into master, thanks @ivmaykov! |
|
@lvfangmin @ivmaykov Isn't this something we introduced as part of Quorum TLS? |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Made some changes to handle the random ENTRY_CREATE events that occasionally fire even though the watcher is created after the file is already written to disk. Should make the test more stable. Author: Ilya Maykov <[email protected]> Closes apache#739 from ivmaykov/ZOOKEEPER-3219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some changes to handle the random ENTRY_CREATE events that occasionally fire even though the watcher is created after the file is already written to disk. Should make the test more stable.