ZOOKEEPER-3061: add more details to 'Unhandled scenario for peer' log.warn message #555
Conversation
There was a problem hiding this comment.
LGTM code wise, jenkins failed due to a flaky test. - Please re run with an empty amend commit for example.
As already mentioned in the jira, the same log is already there on INFO level. I've been warned before for duplicate logs, but seems like it could make debugging from logs easier.
| @@ -792,7 +792,14 @@ public boolean syncFollower(long peerLastZxid, ZKDatabase db, Leader leader) { | |||
| txnProposalItr.close(); | |||
| } | |||
| } else { | |||
| LOG.warn("Unhandled scenario for peer sid: " + getSid()); | |||
| LOG.warn("Unhandled scenario for peer sid: {} maxCommittedLog=0x{}" | |||
There was a problem hiding this comment.
The same context is also provided at line 703 except the txnLogSyncEnabled, looks like nothing changed between these lines, any reason we added this extra logging here?
There was a problem hiding this comment.
the logging levels are different, and it is nice to have the evaluation information with weird corner case scenario. i think it's worth surfacing the information here as well.
| @@ -792,7 +792,14 @@ public boolean syncFollower(long peerLastZxid, ZKDatabase db, Leader leader) { | |||
| txnProposalItr.close(); | |||
| } | |||
| } else { | |||
| LOG.warn("Unhandled scenario for peer sid: " + getSid()); | |||
| LOG.warn("Unhandled scenario for peer sid: {} maxCommittedLog=0x{}" | |||
There was a problem hiding this comment.
the logging levels are different, and it is nice to have the evaluation information with weird corner case scenario. i think it's worth surfacing the information here as well.
….warn message Author: Christine Poerschke <[email protected]> Author: Christine Poerschke <[email protected]> Reviewers: Allan Lyu <[email protected]>, Benjamin Reed <[email protected]>, Norbert Kalmar <[email protected]> Closes apache#555 from cpoerschke/master-ZOOKEEPER-3061 and squashes the following commits: 1399682 [Christine Poerschke] Merge remote-tracking branch 'origin/master' into master-ZOOKEEPER-3061 1840c2b [Christine Poerschke] Merge remote-tracking branch 'origin/master' into master-ZOOKEEPER-3061 1d3e7bc [Christine Poerschke] ZOOKEEPER-3061: add more details to 'Unhandled scenario for peer' log.warn message
No description provided.