ZOOKEEPER-3039 TxnLogToolkit uses Scanner badly #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfgit
pushed a commit
that referenced
this pull request
May 10, 2018
Fixed by creating a single Scanner for all queries in the main() method. Author: Andor Molnar <[email protected]> Reviewers: [email protected] Closes #517 from anmolnar/ZOOKEEPER-3039 and squashes the following commits: a35e2e2 [Andor Molnar] ZOOKEEPER-3039. Optimize imports a196443 [Andor Molnar] ZOOKEEPER-3039. Use the same Scanner for all queries Change-Id: Icf66888d4e6ad902615ed8ffde58a5a8fdd41237 (cherry picked from commit 2fa315b) Signed-off-by: Patrick Hunt <[email protected]>
|
+1. I committed to 3.5 and master however it doesn't apply cleanly to branch-3.4. Please submit a separate PR. |
anmolnar
added a commit
to anmolnar/zookeeper
that referenced
this pull request
May 10, 2018
Fixed by creating a single Scanner for all queries in the main() method. Author: Andor Molnar <[email protected]> Reviewers: [email protected] Closes apache#517 from anmolnar/ZOOKEEPER-3039 and squashes the following commits: a35e2e2 [Andor Molnar] ZOOKEEPER-3039. Optimize imports a196443 [Andor Molnar] ZOOKEEPER-3039. Use the same Scanner for all queries Change-Id: Icf66888d4e6ad902615ed8ffde58a5a8fdd41237
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
Fixed by creating a single Scanner for all queries in the main() method. Author: Andor Molnar <[email protected]> Reviewers: [email protected] Closes apache#517 from anmolnar/ZOOKEEPER-3039 and squashes the following commits: a35e2e2 [Andor Molnar] ZOOKEEPER-3039. Optimize imports a196443 [Andor Molnar] ZOOKEEPER-3039. Use the same Scanner for all queries Change-Id: Icf66888d4e6ad902615ed8ffde58a5a8fdd41237
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Fixed by creating a single Scanner for all queries in the main() method. Author: Andor Molnar <[email protected]> Reviewers: [email protected] Closes apache#517 from anmolnar/ZOOKEEPER-3039 and squashes the following commits: a35e2e2 [Andor Molnar] ZOOKEEPER-3039. Optimize imports a196443 [Andor Molnar] ZOOKEEPER-3039. Use the same Scanner for all queries Change-Id: Icf66888d4e6ad902615ed8ffde58a5a8fdd41237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by creating a single Scanner for all queries in the main() method.