ZOOKEEPER-3038 Cleanup some nitpicks in TTL implementation #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfgit
pushed a commit
that referenced
this pull request
May 10, 2018
A few nitpicks which needs to be cleaned up: 1. Rename OldEphemeralType --> EphemeralTypeEmulate353 2. Remove unused method: getTTL() 3. Remove unused import from QuorumPeer Author: Andor Molnar <[email protected]> Reviewers: [email protected] Closes #516 from anmolnar/ZOOKEEPER-3038 Change-Id: Iec537706a35863d53daa593da2b01f6e523ef466 (cherry picked from commit 6e64125) Signed-off-by: Patrick Hunt <[email protected]>
|
+1 - thanks Andor. |
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
A few nitpicks which needs to be cleaned up: 1. Rename OldEphemeralType --> EphemeralTypeEmulate353 2. Remove unused method: getTTL() 3. Remove unused import from QuorumPeer Author: Andor Molnar <[email protected]> Reviewers: [email protected] Closes apache#516 from anmolnar/ZOOKEEPER-3038 Change-Id: Iec537706a35863d53daa593da2b01f6e523ef466
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
A few nitpicks which needs to be cleaned up: 1. Rename OldEphemeralType --> EphemeralTypeEmulate353 2. Remove unused method: getTTL() 3. Remove unused import from QuorumPeer Author: Andor Molnar <[email protected]> Reviewers: [email protected] Closes apache#516 from anmolnar/ZOOKEEPER-3038 Change-Id: Iec537706a35863d53daa593da2b01f6e523ef466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few nitpicks which needs to be cleaned up: