-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZOOKEEPER-4545 Backport auto reloading client key/trust store to 3.7 #1884
Conversation
@eolivelli @symat would you mind taking a look at the PR? Thanks. |
7d05e15
to
ca5cb61
Compare
This is cherry-pick from apache#1839. This PR is the same as the apache#1839 on the master branch, only changing the documentation about the version numbers. Signed-off-by: Li Wang <[email protected]>
Looks OK, waiting for CI to finish |
thanks @symat ! |
Need one more approval for getting it merged. @eolivelli would you mind reviewing it? Thanks. |
can @eolivelli or anyone help approving the back-port PR? It would be greatly appreciated if it can be merged, so we don't need to manually rebooting the 3.7 clusters in production. Thanks a lot! |
@symat do you know if any other committer is available and can help with approving the PR? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks! I'm merging it now to branch-3.7 |
ZOOKEEPER-4545 Backport auto reloading client key/trust store to 3.7 This is cherry-pick from #1839. This PR is the same as the #1839 on the master branch, only changing the documentation about the version numbers. Signed-off-by: Li Wang <li4wanggmail.com> Author: Manu Mathew <[email protected]> Reviewers: Enrico Olivelli <[email protected]>, Mate Szalay-Beko <[email protected]> Closes #1884 from li4wang/ZOOKEEPER-4545
thank you @li4wang for the contribution! |
thanks a lot for getting this in @symat and @eolivelli ! |
ZOOKEEPER-4545 Backport auto reloading client key/trust store to 3.7
This is cherry-pick from #1839. This PR is the same as the #1839 on the master branch, only changing the documentation about the version numbers.
Signed-off-by: Li Wang [email protected]