Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4545 Backport auto reloading client key/trust store to 3.7 #1884

Closed
wants to merge 1 commit into from

Conversation

li4wang
Copy link
Contributor

@li4wang li4wang commented May 23, 2022

ZOOKEEPER-4545 Backport auto reloading client key/trust store to 3.7

This is cherry-pick from #1839. This PR is the same as the #1839 on the master branch, only changing the documentation about the version numbers.

Signed-off-by: Li Wang [email protected]

@li4wang
Copy link
Contributor Author

li4wang commented May 23, 2022

@eolivelli @symat would you mind taking a look at the PR? Thanks.

@li4wang li4wang changed the title ZOOKEEPER-3806: TLS - dynamic loading for client trust/key store ZOOKEEPER-4545 Backport auto reloading client key/trust store to 3.7 May 24, 2022
@li4wang li4wang force-pushed the ZOOKEEPER-4545 branch 2 times, most recently from 7d05e15 to ca5cb61 Compare May 24, 2022 00:56
This is cherry-pick from apache#1839. This PR is the same as the apache#1839 on the master branch, only changing the documentation about the version numbers.

Signed-off-by: Li Wang <[email protected]>
@symat
Copy link
Contributor

symat commented May 24, 2022

Looks OK, waiting for CI to finish

@li4wang
Copy link
Contributor Author

li4wang commented May 24, 2022

thanks @symat !

@li4wang
Copy link
Contributor Author

li4wang commented May 31, 2022

Need one more approval for getting it merged. @eolivelli would you mind reviewing it? Thanks.

@li4wang
Copy link
Contributor Author

li4wang commented Jun 9, 2022

can @eolivelli or anyone help approving the back-port PR? It would be greatly appreciated if it can be merged, so we don't need to manually rebooting the 3.7 clusters in production. Thanks a lot!

@li4wang
Copy link
Contributor Author

li4wang commented Jun 16, 2022

@symat do you know if any other committer is available and can help with approving the PR? Thanks.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@symat
Copy link
Contributor

symat commented Jun 16, 2022

thanks! I'm merging it now to branch-3.7

asfgit pushed a commit that referenced this pull request Jun 16, 2022
ZOOKEEPER-4545 Backport auto reloading client key/trust store to 3.7

This is cherry-pick from #1839. This PR is the same as the #1839 on the master branch, only changing the documentation about the version numbers.

Signed-off-by: Li Wang <li4wanggmail.com>

Author: Manu Mathew <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Mate Szalay-Beko <[email protected]>

Closes #1884 from li4wang/ZOOKEEPER-4545
@symat
Copy link
Contributor

symat commented Jun 16, 2022

thank you @li4wang for the contribution!
this will be part of release 3.7.2.

@li4wang
Copy link
Contributor Author

li4wang commented Jun 16, 2022

thanks a lot for getting this in @symat and @eolivelli !

@symat symat closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants