ZOOKEEPER-2687:Deadlock while shutting down the Leader server. #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is not test case, as the change is very simple and understandable and the test will complicate the overall fix. |
|
+1 lgtm looked through he code and i did not see any other places where this particular deadlock occurs |
rakeshadr
reviewed
Feb 15, 2017
| @@ -590,8 +590,8 @@ void lead() throws IOException, InterruptedException { | |||
|
|
|||
| // check leader running status | |||
| if (!this.isRunning()) { | |||
| shutdown("Unexpected internal error"); | |||
| return; | |||
| shutdownMessage = "Unexpected internal error"; | |||
There was a problem hiding this comment.
Good catch @arshadmohammad. Yes, this is another code where it can leads to deadlock similar to ZK-2380.
As we know, shutdownMessage is acting as flag. Could you please add comments to make this clear,
// set shutdown flag
shutdownMessage = "Unexpected internal error";`
|
+1 LGTM, I will merge this to branch-3.5 and master shortly. |
asfgit
pushed a commit
that referenced
this pull request
Feb 15, 2017
Leader server enters into deadlock while shutting down itself. Shutdown of the leader server is called from the synchronized block which must be called from outside the synchronized block. For detail pls refer ZOOKEEPER-2380 Author: Mohammad Arshad <[email protected]> Reviewers: Abraham Fine <[email protected]>, Rakesh Radhakrishnan <[email protected]> Closes #176 from arshadmohammad/ZOOKEEPER-2687 and squashes the following commits: 7551f5c [Mohammad Arshad] Fixed Rakesh's comments 1e3ed70 [Mohammad Arshad] ZOOKEEPER-2687:Deadlock while shutting down the Leader server. (cherry picked from commit fd211a5) Signed-off-by: Rakesh Radhakrishnan <[email protected]>
lvfangmin
pushed a commit
to lvfangmin/zookeeper
that referenced
this pull request
Jun 17, 2018
Leader server enters into deadlock while shutting down itself. Shutdown of the leader server is called from the synchronized block which must be called from outside the synchronized block. For detail pls refer ZOOKEEPER-2380 Author: Mohammad Arshad <[email protected]> Reviewers: Abraham Fine <[email protected]>, Rakesh Radhakrishnan <[email protected]> Closes apache#176 from arshadmohammad/ZOOKEEPER-2687 and squashes the following commits: 7551f5c [Mohammad Arshad] Fixed Rakesh's comments 1e3ed70 [Mohammad Arshad] ZOOKEEPER-2687:Deadlock while shutting down the Leader server.
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Leader server enters into deadlock while shutting down itself. Shutdown of the leader server is called from the synchronized block which must be called from outside the synchronized block. For detail pls refer ZOOKEEPER-2380 Author: Mohammad Arshad <[email protected]> Reviewers: Abraham Fine <[email protected]>, Rakesh Radhakrishnan <[email protected]> Closes apache#176 from arshadmohammad/ZOOKEEPER-2687 and squashes the following commits: 7551f5c [Mohammad Arshad] Fixed Rakesh's comments 1e3ed70 [Mohammad Arshad] ZOOKEEPER-2687:Deadlock while shutting down the Leader server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leader server enters into deadlock while shutting down itself. Shutdown of the leader server is called from the synchronized block which must be called from outside the synchronized block. For detail pls refer ZOOKEEPER-2380