ZOOKEEPER-4221: Improve the error message when message goes above jute.maxbufer size

[mariemat]

No description provided.

[mariemat]

HI,

The CI failed with a timeout.

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.zookeeper.server.quorum.Zab1_0Test
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.352 s - in org.apache.zookeeper.server.quorum.Zab1_0Test
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0

I reran the following successfully:

mvn -Dtest=Zab1_0Test  -Pfull-build verify -Dsurefire-forkcount=1 -DskipCppUnit -Dsurefire.rerunFailingTestsCount=5
...
[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.zookeeper.server.quorum.Zab1_0Test
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.352 s - in org.apache.zookeeper.server.quorum.Zab1_0Test
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 43.262 s
[INFO] Finished at: 2021-02-24T20:53:12+01:00

Is there a way to rerun the CI?

[symat]

LGTM, great, thank you!

we can re-trigger the CI job on jenkins / travis / wherever (I'm not really sure). But this was a quite trivial change and also AFAICS only the java 11 unit tests timeouted, so I wouldn't care much...

@ztzg , @maoling PTAL - I remember an other PR where we discussed some logging improvement with one of you around the jute.maxbuffer. (but it is also very possible that I remember wrong... anyway, can you take a look?)

[symat]

using the link on the failed GitHub CI job (the one with label "Details"), you can select "Rerun Jobs". But that would re-run all GitHub based CI jobs for this PR, and that potentially can cause more flaky tests. So I think this is good enough.

(we are working right now in the community to stabilize the CI for the master branch, as it is less reliable than it used to be)

[symat]

anyway, I just re-triggered the job. (actually there is only a single GitHub check that is running the java unit tests)
it succeeded now

[ztzg]

LGTM!

@symat wrote:

I remember an other PR where we discussed some logging improvement with one of you around the jute.maxbuffer.

I suppose it was #1580, which predates this submission, but whose message is a bit less informative.

(we are working right now in the community to stabilize the CI for the master branch, as it is less reliable than it used to be)

Indeed. And FWIW, I had noted the failing test (Zab1_0Test.testNormalFollowerRunWithDiff, failing at Zab1_0Test.java:790); once more, the failure can be ascribed to a timing assumption. I've been collecting a few of those, and am planning to submit patches at some point.

[symat]

thanks @ztzg for the review! :)

[symat]

I'm merging it now.

[symat]

@ztzg I merged this to master and branch-3.7. I think this can go to 3.7.0. Do I need to cherry-pick this to some 3.7.0 release branch, or you will cut a new release branch from branch-3.7 later?

[ztzg]

Hi @symat, thank you.

@ztzg I merged this to master and branch-3.7. I think this can go to 3.7.0. Do I need to cherry-pick this to some 3.7.0 release branch, or you will cut a new release branch from branch-3.7 later?

Same as #1611 (comment): don't worry about it, as I have to reconcile both branches anyway. I have added this ticket to my list of things to check.

[ztzg]

Hi @symat, thank you.

@ztzg I merged this to master and branch-3.7. I think this can go to 3.7.0. Do I need to cherry-pick this to some 3.7.0 release branch, or you will cut a new release branch from branch-3.7 later?

Same as #1611 (comment): don't worry about it, as I have to reconcile both branches anyway. I have added this ticket to my list of things to check.

Now also in branch-3.7.0. Thanks!