Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4212: add committer checklist to zk-merge-pr.py #1610

Closed
wants to merge 1 commit into from

Conversation

maoling
Copy link
Member

@maoling maoling commented Feb 21, 2021

  • Add the committer checklist to commit script to avoid The Accident Case like: PR-1597
  • more details in the ZOOKEEPER-4212

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we need this stuff.
We are all responsible for what we are doing and we always wait for at least 2 binding +1.

We can always git revert.

I appreciate very much this proposal and I feel your feelings about your incident.

I would like not to commit this patch.

So -0 from my side

@maoling
Copy link
Member Author

maoling commented Feb 26, 2021

@eolivelli That's OK. If your guys don't want it, let it be my private commit script copy to give me a checklist to avoid unexpected accidents when I commit something:)

@symat
Copy link
Contributor

symat commented Mar 12, 2021

I can only repeat myself: I really don't think you should have bad feelings about PR-1597. It wasn't a big deal at all. We all make mistakes, but as Enrico mentioned, there is nothing we couldn't fix in git :)

And also we have a great community that is continuously monitoring / testing things, which gives us a great confidence in ZooKeeper quality for the released versions.

Copy link
Contributor

@anmolnar anmolnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maoling I owe you an apology if I hurt your feelings with my e-mail. I'm sorry, I didn't mean that, I was really just kidding, but this is not fun anymore.
No need for this list in the codebase and you don't need it either. Please close this PR.

@maoling maoling closed this Mar 12, 2021
@maoling maoling deleted the ZOOKEEPER-4212 branch March 12, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants