Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-2693: Correct the documentation about response to "ruok" 4lw #1608

Closed
wants to merge 2 commits into from

Conversation

nemobis
Copy link

@nemobis nemobis commented Feb 18, 2021

Since 5fe6850, it's no longer true that the server will either respond
or not; now it can also respond that it won't obey, with the message that
the command "is not executed because it is not in the whitelist", unlike
what one gets if the command does not exist at all.

Author: Federico Leva [email protected]

Since 5fe6850, it's no longer true that the server will either respond
or not; now it can also respond that it won't obey, with the message that
the command "is not executed because it is not in the whitelist", unlike
what one gets if the command does not exist at all.

Author: Federico Leva <[email protected]>
@nemobis
Copy link
Author

nemobis commented Feb 21, 2021 via email

Copy link
Member

@maoling maoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. LGTM. Please be patient to wait for another vote, then we can merge it asap.
Thanks for your contribution.

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@maoling can you please merge? Thanks

@maoling
Copy link
Member

maoling commented Mar 2, 2021

It's not 2021-05-10 yet:) @eolivelli Could you please merge? Thanks!!!

@ztzg ztzg closed this in f39caf6 Mar 6, 2021
@ztzg
Copy link
Contributor

ztzg commented Mar 6, 2021

I have merged this in master to avoid waiting another couple of months :) But @maoling, I think you should reconsider your position!

P.-S. — I noticed (too late) that the ticket # was not quite about this documentation topic, but I suppose it's close enough:

https://issues.apache.org/jira/browse/ZOOKEEPER-2693

RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
Since 5fe6850, it's no longer true that the server will either respond
or not; now it can also respond that it won't obey, with the message that
the command "is not executed because it is not in the whitelist", unlike
what one gets if the command does not exist at all.

Author: Federico Leva <[email protected]>

Reviewers: maoling <[email protected]>, Enrico Olivelli <[email protected]>

Closes apache#1608 from nemobis/ZOOKEEPER-2693
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
Since 5fe6850, it's no longer true that the server will either respond
or not; now it can also respond that it won't obey, with the message that
the command "is not executed because it is not in the whitelist", unlike
what one gets if the command does not exist at all.

Author: Federico Leva <[email protected]>

Reviewers: maoling <[email protected]>, Enrico Olivelli <[email protected]>

Closes apache#1608 from nemobis/ZOOKEEPER-2693
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
Since 5fe6850, it's no longer true that the server will either respond
or not; now it can also respond that it won't obey, with the message that
the command "is not executed because it is not in the whitelist", unlike
what one gets if the command does not exist at all.

Author: Federico Leva <[email protected]>

Reviewers: maoling <[email protected]>, Enrico Olivelli <[email protected]>

Closes apache#1608 from nemobis/ZOOKEEPER-2693
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
Since 5fe6850, it's no longer true that the server will either respond
or not; now it can also respond that it won't obey, with the message that
the command "is not executed because it is not in the whitelist", unlike
what one gets if the command does not exist at all.

Author: Federico Leva <[email protected]>

Reviewers: maoling <[email protected]>, Enrico Olivelli <[email protected]>

Closes apache#1608 from nemobis/ZOOKEEPER-2693
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 29, 2022
Since 5fe6850, it's no longer true that the server will either respond
or not; now it can also respond that it won't obey, with the message that
the command "is not executed because it is not in the whitelist", unlike
what one gets if the command does not exist at all.

Author: Federico Leva <[email protected]>

Reviewers: maoling <[email protected]>, Enrico Olivelli <[email protected]>

Closes apache#1608 from nemobis/ZOOKEEPER-2693
anuragmadnawat1 pushed a commit to anuragmadnawat1/zookeeper that referenced this pull request Nov 2, 2022
Since 5fe6850, it's no longer true that the server will either respond
or not; now it can also respond that it won't obey, with the message that
the command "is not executed because it is not in the whitelist", unlike
what one gets if the command does not exist at all.

Author: Federico Leva <[email protected]>

Reviewers: maoling <[email protected]>, Enrico Olivelli <[email protected]>

Closes apache#1608 from nemobis/ZOOKEEPER-2693
anuragmadnawat1 added a commit to anuragmadnawat1/zookeeper that referenced this pull request Nov 2, 2022
#113)

Since 5fe6850, it's no longer true that the server will either respond
or not; now it can also respond that it won't obey, with the message that
the command "is not executed because it is not in the whitelist", unlike
what one gets if the command does not exist at all.

Author: Federico Leva <[email protected]>

Reviewers: maoling <[email protected]>, Enrico Olivelli <[email protected]>

Closes apache#1608 from nemobis/ZOOKEEPER-2693

Co-authored-by: Federico Leva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants