Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-4214: Update Netty to 4.1.59.Final on Ivy build for 3.5 branch #1607

Closed
wants to merge 2 commits into from

Conversation

frederiko
Copy link
Contributor

@frederiko frederiko commented Feb 17, 2021

Update Netty to 4.1.59.Final on to address a vulnerability

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkalmar @symat PTAL

thank you @frederiko !

Copy link
Contributor

@ztzg ztzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (I'll let @nkalmar and @symat have a final look.)

ztzg pushed a commit that referenced this pull request Mar 7, 2021
On PR #1605 eolivelli requested to also update the Ivy dependency file. This PR address the comment on #1605 (comment)

Author: Frederiko Costa <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Damien Diederen <[email protected]>

Closes #1607 from frederiko/ivy-update
@ztzg
Copy link
Contributor

ztzg commented Mar 7, 2021

Now in branch-3.5. Thank you, @frederiko!

Copy link
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, merging

@nkalmar
Copy link
Contributor

nkalmar commented Mar 12, 2021

for some reason merge script keeps failing on this PR, need to sort that out first.

@nkalmar
Copy link
Contributor

nkalmar commented Mar 12, 2021

updated first PR comment as script takes it as commit message, and it had an invalid character

@ztzg
Copy link
Contributor

ztzg commented Mar 12, 2021

@nkalmar: Wait—I already merged this in branch-3.5 on 2021-03-07, but the PR did not get closed for some reason. Closing it manually now; please reopen if I missed something!

@ztzg ztzg closed this Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants