ZOOKEEPER-4191: Work around missing executable bits in source release tarball #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztzg
added a commit
that referenced
this pull request
Jan 24, 2021
… tarball symat noticed that the source tarball for 3.7.0rc0 is missing executable bits. ztzg noticed that this can be worked around by reinstating the "old" version of the maven-assembly-plugin, which had been aligned in ZOOKEEPER-3833. This patch implements the work around, and also applies cleanly on top of `branch-3.7.0` and `branch-3.7`. Also discussed on dev: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3C875z3n9w75.fsf%40crosstwine.com%3E Original report: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3cCAAMoRKLMf7tLosgqyiwYfFxXq-Zmiz=0oTGDijX5M=MHDF_JCgmail.gmail.com%3e Author: Damien Diederen <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes #1586 from ztzg/ZOOKEEPER-4191-missing-x-bits-source-tarball (cherry picked from commit e7d67da) Signed-off-by: Damien Diederen <[email protected]>
ztzg
added a commit
that referenced
this pull request
Jan 24, 2021
… tarball symat noticed that the source tarball for 3.7.0rc0 is missing executable bits. ztzg noticed that this can be worked around by reinstating the "old" version of the maven-assembly-plugin, which had been aligned in ZOOKEEPER-3833. This patch implements the work around, and also applies cleanly on top of `branch-3.7.0` and `branch-3.7`. Also discussed on dev: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3C875z3n9w75.fsf%40crosstwine.com%3E Original report: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3cCAAMoRKLMf7tLosgqyiwYfFxXq-Zmiz=0oTGDijX5M=MHDF_JCgmail.gmail.com%3e Author: Damien Diederen <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes #1586 from ztzg/ZOOKEEPER-4191-missing-x-bits-source-tarball (cherry picked from commit e7d67da) Signed-off-by: Damien Diederen <[email protected]>
|
Thank you for the quick review, @eolivelli. Now merged. |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
… tarball symat noticed that the source tarball for 3.7.0rc0 is missing executable bits. ztzg noticed that this can be worked around by reinstating the "old" version of the maven-assembly-plugin, which had been aligned in ZOOKEEPER-3833. This patch implements the work around, and also applies cleanly on top of `branch-3.7.0` and `branch-3.7`. Also discussed on dev: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3C875z3n9w75.fsf%40crosstwine.com%3E Original report: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3cCAAMoRKLMf7tLosgqyiwYfFxXq-Zmiz=0oTGDijX5M=MHDF_JCgmail.gmail.com%3e Author: Damien Diederen <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1586 from ztzg/ZOOKEEPER-4191-missing-x-bits-source-tarball
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
… tarball symat noticed that the source tarball for 3.7.0rc0 is missing executable bits. ztzg noticed that this can be worked around by reinstating the "old" version of the maven-assembly-plugin, which had been aligned in ZOOKEEPER-3833. This patch implements the work around, and also applies cleanly on top of `branch-3.7.0` and `branch-3.7`. Also discussed on dev: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3C875z3n9w75.fsf%40crosstwine.com%3E Original report: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3cCAAMoRKLMf7tLosgqyiwYfFxXq-Zmiz=0oTGDijX5M=MHDF_JCgmail.gmail.com%3e Author: Damien Diederen <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1586 from ztzg/ZOOKEEPER-4191-missing-x-bits-source-tarball
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
… tarball symat noticed that the source tarball for 3.7.0rc0 is missing executable bits. ztzg noticed that this can be worked around by reinstating the "old" version of the maven-assembly-plugin, which had been aligned in ZOOKEEPER-3833. This patch implements the work around, and also applies cleanly on top of `branch-3.7.0` and `branch-3.7`. Also discussed on dev: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3C875z3n9w75.fsf%40crosstwine.com%3E Original report: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3cCAAMoRKLMf7tLosgqyiwYfFxXq-Zmiz=0oTGDijX5M=MHDF_JCgmail.gmail.com%3e Author: Damien Diederen <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1586 from ztzg/ZOOKEEPER-4191-missing-x-bits-source-tarball
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
… tarball symat noticed that the source tarball for 3.7.0rc0 is missing executable bits. ztzg noticed that this can be worked around by reinstating the "old" version of the maven-assembly-plugin, which had been aligned in ZOOKEEPER-3833. This patch implements the work around, and also applies cleanly on top of `branch-3.7.0` and `branch-3.7`. Also discussed on dev: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3C875z3n9w75.fsf%40crosstwine.com%3E Original report: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3cCAAMoRKLMf7tLosgqyiwYfFxXq-Zmiz=0oTGDijX5M=MHDF_JCgmail.gmail.com%3e Author: Damien Diederen <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1586 from ztzg/ZOOKEEPER-4191-missing-x-bits-source-tarball
anuragmadnawat1
pushed a commit
to anuragmadnawat1/zookeeper
that referenced
this pull request
Nov 2, 2022
… tarball symat noticed that the source tarball for 3.7.0rc0 is missing executable bits. ztzg noticed that this can be worked around by reinstating the "old" version of the maven-assembly-plugin, which had been aligned in ZOOKEEPER-3833. This patch implements the work around, and also applies cleanly on top of `branch-3.7.0` and `branch-3.7`. Also discussed on dev: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3C875z3n9w75.fsf%40crosstwine.com%3E Original report: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3cCAAMoRKLMf7tLosgqyiwYfFxXq-Zmiz=0oTGDijX5M=MHDF_JCgmail.gmail.com%3e Author: Damien Diederen <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1586 from ztzg/ZOOKEEPER-4191-missing-x-bits-source-tarball
anuragmadnawat1
pushed a commit
to anuragmadnawat1/zookeeper
that referenced
this pull request
Nov 2, 2022
… tarball symat noticed that the source tarball for 3.7.0rc0 is missing executable bits. ztzg noticed that this can be worked around by reinstating the "old" version of the maven-assembly-plugin, which had been aligned in ZOOKEEPER-3833. This patch implements the work around, and also applies cleanly on top of `branch-3.7.0` and `branch-3.7`. Also discussed on dev: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3C875z3n9w75.fsf%40crosstwine.com%3E Original report: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3cCAAMoRKLMf7tLosgqyiwYfFxXq-Zmiz=0oTGDijX5M=MHDF_JCgmail.gmail.com%3e Author: Damien Diederen <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1586 from ztzg/ZOOKEEPER-4191-missing-x-bits-source-tarball
anuragmadnawat1
added a commit
to anuragmadnawat1/zookeeper
that referenced
this pull request
Nov 2, 2022
… tarball (#90) symat noticed that the source tarball for 3.7.0rc0 is missing executable bits. ztzg noticed that this can be worked around by reinstating the "old" version of the maven-assembly-plugin, which had been aligned in ZOOKEEPER-3833. This patch implements the work around, and also applies cleanly on top of `branch-3.7.0` and `branch-3.7`. Also discussed on dev: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3C875z3n9w75.fsf%40crosstwine.com%3E Original report: https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3cCAAMoRKLMf7tLosgqyiwYfFxXq-Zmiz=0oTGDijX5M=MHDF_JCgmail.gmail.com%3e Author: Damien Diederen <[email protected]> Reviewers: Enrico Olivelli <[email protected]> Closes apache#1586 from ztzg/ZOOKEEPER-4191-missing-x-bits-source-tarball Co-authored-by: Damien Diederen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@symat noticed that the source tarball for 3.7.0rc0 is missing executable bits.
@ztzg noticed that this can be worked around by reinstating the "old" version of the maven-assembly-plugin, which had been aligned in ZOOKEEPER-3833.
This patch implements the work around, and also applies cleanly on top of
branch-3.7.0andbranch-3.7.Also discussed on dev@:
https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3C875z3n9w75.fsf%40crosstwine.com%3E
Original report:
https://mail-archives.apache.org/mod_mbox/zookeeper-dev/202101.mbox/%3cCAAMoRKLMf7tLosgqyiwYfFxXq-Zmiz=0oTGDijX5M=MHDF_JCg@mail.gmail.com%3e