ZOOKEEPER-3782: Replace filter() with list comprehension for returning list #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @anmolnar Please verify the change. I'm sorry that I don't spot it earlier :( |
|
committed |
stickyhipp
pushed a commit
to stickyhipp/zookeeper
that referenced
this pull request
Aug 19, 2020
…g list
After Py3, `filter` return a `filter object` instead of `list object`, which causes
```
Traceback (most recent call last):
File "zk-merge-pr.py", line 533, in <module>
main()
File "zk-merge-pr.py", line 519, in main
resolve_jira_issues(commit_title, merged_refs, jira_comment)
File "zk-merge-pr.py", line 329, in resolve_jira_issues
resolve_jira_issue(merge_branches, comment, jira_id)
File "zk-merge-pr.py", line 312, in resolve_jira_issue
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 312, in <listcomp>
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 310, in get_version_json
return filter(lambda v: v.name == version_str, versions)[0].raw
TypeError: 'filter' object is not subscriptable
```
We can replace filter with list comprehension to fix it.
Author: tison <[email protected]>
Reviewers: Enrico Olivelli <[email protected]>
Closes apache#1303 from TisonKun/ZOOKEEPER-3782
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
…g list
After Py3, `filter` return a `filter object` instead of `list object`, which causes
```
Traceback (most recent call last):
File "zk-merge-pr.py", line 533, in <module>
main()
File "zk-merge-pr.py", line 519, in main
resolve_jira_issues(commit_title, merged_refs, jira_comment)
File "zk-merge-pr.py", line 329, in resolve_jira_issues
resolve_jira_issue(merge_branches, comment, jira_id)
File "zk-merge-pr.py", line 312, in resolve_jira_issue
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 312, in <listcomp>
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 310, in get_version_json
return filter(lambda v: v.name == version_str, versions)[0].raw
TypeError: 'filter' object is not subscriptable
```
We can replace filter with list comprehension to fix it.
Author: tison <[email protected]>
Reviewers: Enrico Olivelli <[email protected]>
Closes apache#1303 from TisonKun/ZOOKEEPER-3782
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
…g list
After Py3, `filter` return a `filter object` instead of `list object`, which causes
```
Traceback (most recent call last):
File "zk-merge-pr.py", line 533, in <module>
main()
File "zk-merge-pr.py", line 519, in main
resolve_jira_issues(commit_title, merged_refs, jira_comment)
File "zk-merge-pr.py", line 329, in resolve_jira_issues
resolve_jira_issue(merge_branches, comment, jira_id)
File "zk-merge-pr.py", line 312, in resolve_jira_issue
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 312, in <listcomp>
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 310, in get_version_json
return filter(lambda v: v.name == version_str, versions)[0].raw
TypeError: 'filter' object is not subscriptable
```
We can replace filter with list comprehension to fix it.
Author: tison <[email protected]>
Reviewers: Enrico Olivelli <[email protected]>
Closes apache#1303 from TisonKun/ZOOKEEPER-3782
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Aug 31, 2022
…g list
After Py3, `filter` return a `filter object` instead of `list object`, which causes
```
Traceback (most recent call last):
File "zk-merge-pr.py", line 533, in <module>
main()
File "zk-merge-pr.py", line 519, in main
resolve_jira_issues(commit_title, merged_refs, jira_comment)
File "zk-merge-pr.py", line 329, in resolve_jira_issues
resolve_jira_issue(merge_branches, comment, jira_id)
File "zk-merge-pr.py", line 312, in resolve_jira_issue
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 312, in <listcomp>
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 310, in get_version_json
return filter(lambda v: v.name == version_str, versions)[0].raw
TypeError: 'filter' object is not subscriptable
```
We can replace filter with list comprehension to fix it.
Author: tison <[email protected]>
Reviewers: Enrico Olivelli <[email protected]>
Closes apache#1303 from TisonKun/ZOOKEEPER-3782
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
…g list
After Py3, `filter` return a `filter object` instead of `list object`, which causes
```
Traceback (most recent call last):
File "zk-merge-pr.py", line 533, in <module>
main()
File "zk-merge-pr.py", line 519, in main
resolve_jira_issues(commit_title, merged_refs, jira_comment)
File "zk-merge-pr.py", line 329, in resolve_jira_issues
resolve_jira_issue(merge_branches, comment, jira_id)
File "zk-merge-pr.py", line 312, in resolve_jira_issue
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 312, in <listcomp>
jira_fix_versions = [get_version_json(v) for v in fix_versions]
File "zk-merge-pr.py", line 310, in get_version_json
return filter(lambda v: v.name == version_str, versions)[0].raw
TypeError: 'filter' object is not subscriptable
```
We can replace filter with list comprehension to fix it.
Author: tison <[email protected]>
Reviewers: Enrico Olivelli <[email protected]>
Closes apache#1303 from TisonKun/ZOOKEEPER-3782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Py3,
filterreturn afilter objectinstead oflist object, which causesWe can replace filter with list comprehension to fix it.