Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3739: Remove unsupported com.sun API #1269

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-3739: Remove unsupported com.sun API #1269

wants to merge 1 commit into from

Conversation

ctubbsii
Copy link
Member

Remove unsupported use of com.sun.nio.file.SensitivityWatchEventModifier
to better support builds against newer JDKs.

Also update build tooling to use strict JDK release compatibility when
building with newer JDKs by adding profiles which automatically activate
the correct compiler flag when the newer JDK is detected when building
with Maven or Eclipse.

@ctubbsii
ZOOKEEPER-3739: Remove unsupported com.sun API
3484479 
Remove unsupported use of com.sun.nio.file.SensitivityWatchEventModifier
to better support builds against newer JDKs.

Also update build tooling to use strict JDK release compatibility when
building with newer JDKs by adding profiles which automatically activate
the correct compiler flag when the newer JDK is detected when building
with Maven or Eclipse.
eolivelli
eolivelli requested changes Feb 25, 2020
View reviewed changes
zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java Show resolved Hide resolved
pom.xml
<jdk>[9,)</jdk>
</activation>
<properties>
<maven.compiler.release>8</maven.compiler.release>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@eolivelli
Copy link
Contributor

We have to wait for any other committer to approve this patch.
If you want you can ping for review on [email protected]

@ctubbsii
Copy link
Member Author

ctubbsii commented Mar 8, 2020

We have to wait for any other committer to approve this patch.
If you want you can ping for review on [email protected]

Okay. I tried that a few days ago and didn't get a response. Sorry for the impatience 😺

eolivelli
eolivelli approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Sorry I missed to click on the final "Approve" button.

@nkalmar @sysmat this could go into 3.6.1 as well

nkalmar
nkalmar approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

zookeeper-server/src/main/java/org/apache/zookeeper/common/FileChangeWatcher.java Show resolved Hide resolved
@asfgit asfgit closed this in 8148f96 Mar 20, 2020
asfgit pushed a commit that referenced this pull request Mar 20, 2020
@ctubbsii @nkalmar
ZOOKEEPER-3739: Remove unsupported com.sun API
d3ac233 
Remove unsupported use of com.sun.nio.file.SensitivityWatchEventModifier
to better support builds against newer JDKs.

Also update build tooling to use strict JDK release compatibility when
building with newer JDKs by adding profiles which automatically activate
the correct compiler flag when the newer JDK is detected when building
with Maven or Eclipse.

Author: Christopher Tubbs <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes #1269 from ctubbsii/ZK-3739

(cherry picked from commit 8148f96)
Signed-off-by: Norbert Kalmar <[email protected]>
@nkalmar
Copy link
Contributor

nkalmar commented Mar 20, 2020

merged to master and branch-3.6, thanks @ctubbsii

@ctubbsii
Copy link
Member Author

Cool, thanks!

@ctubbsii ctubbsii deleted the ZK-3739 branch March 20, 2020 15:57
anmolnar pushed a commit to anmolnar/zookeeper that referenced this pull request Apr 28, 2020
@ctubbsii @anmolnar
ZOOKEEPER-3739: Remove unsupported com.sun API
af40615 
Remove unsupported use of com.sun.nio.file.SensitivityWatchEventModifier
to better support builds against newer JDKs.

Also update build tooling to use strict JDK release compatibility when
building with newer JDKs by adding profiles which automatically activate
the correct compiler flag when the newer JDK is detected when building
with Maven or Eclipse.

Author: Christopher Tubbs <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1269 from ctubbsii/ZK-3739
@anmolnar anmolnar mentioned this pull request Apr 28, 2020
Closed
asfgit pushed a commit that referenced this pull request Apr 28, 2020
@ctubbsii @symat
ZOOKEEPER-3739: Remove use of com.sun.nio.file.SensitivityWatchEventM…
35f7a8e 
…odifier

3.5 backport of #1269

Author: Christopher Tubbs <[email protected]>

Reviewers: Andor Molnar <[email protected]>, Enrico Olivelli <[email protected]>, Mate Szalay-Beko <[email protected]>

Closes #1340 from anmolnar/ZOOKEEPER-3215_35
stickyhipp pushed a commit to stickyhipp/zookeeper that referenced this pull request Aug 19, 2020
@ctubbsii @stickyhipp
ZOOKEEPER-3739: Remove unsupported com.sun API
40a2b10 
Remove unsupported use of com.sun.nio.file.SensitivityWatchEventModifier
to better support builds against newer JDKs.

Also update build tooling to use strict JDK release compatibility when
building with newer JDKs by adding profiles which automatically activate
the correct compiler flag when the newer JDK is detected when building
with Maven or Eclipse.

Author: Christopher Tubbs <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1269 from ctubbsii/ZK-3739
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@ctubbsii @RokLenarcic
ZOOKEEPER-3739: Remove unsupported com.sun API
75bba51 
Remove unsupported use of com.sun.nio.file.SensitivityWatchEventModifier
to better support builds against newer JDKs.

Also update build tooling to use strict JDK release compatibility when
building with newer JDKs by adding profiles which automatically activate
the correct compiler flag when the newer JDK is detected when building
with Maven or Eclipse.

Author: Christopher Tubbs <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1269 from ctubbsii/ZK-3739
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@ctubbsii @RokLenarcic
ZOOKEEPER-3739: Remove unsupported com.sun API
18d7e19 
Remove unsupported use of com.sun.nio.file.SensitivityWatchEventModifier
to better support builds against newer JDKs.

Also update build tooling to use strict JDK release compatibility when
building with newer JDKs by adding profiles which automatically activate
the correct compiler flag when the newer JDK is detected when building
with Maven or Eclipse.

Author: Christopher Tubbs <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1269 from ctubbsii/ZK-3739
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@ctubbsii @RokLenarcic
ZOOKEEPER-3739: Remove unsupported com.sun API
87228dd 
Remove unsupported use of com.sun.nio.file.SensitivityWatchEventModifier
to better support builds against newer JDKs.

Also update build tooling to use strict JDK release compatibility when
building with newer JDKs by adding profiles which automatically activate
the correct compiler flag when the newer JDK is detected when building
with Maven or Eclipse.

Author: Christopher Tubbs <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1269 from ctubbsii/ZK-3739
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@ctubbsii @RokLenarcic
ZOOKEEPER-3739: Remove unsupported com.sun API
1c4ec87 
Remove unsupported use of com.sun.nio.file.SensitivityWatchEventModifier
to better support builds against newer JDKs.

Also update build tooling to use strict JDK release compatibility when
building with newer JDKs by adding profiles which automatically activate
the correct compiler flag when the newer JDK is detected when building
with Maven or Eclipse.

Author: Christopher Tubbs <[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1269 from ctubbsii/ZK-3739
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@nkalmar nkalmar nkalmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctubbsii @eolivelli @nkalmar