Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3703 - publish a test JAR #1229

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-3703 - publish a test JAR #1229

wants to merge 1 commit into from

Conversation

Randgalt
Copy link
Member

@Randgalt Randgalt commented Jan 21, 2020 •
edited
Loading

It would be very helpful to Apache Curator and others if ZooKeeper published its testing code as a Maven Test JAR. Curator, for example, could use it to improve its testing server to make it easier to inject error conditions without having to have forced time delays and other hacks.

NOTE: if we move forward with gRPC (ZOOKEEPER-102) that would be in a new module and this would be required. So, might as well do it now.

@Randgalt Randgalt requested a review from eolivelli January 21, 2020 21:35
eolivelli
eolivelli approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Users should be aware that this won't be some kind of public API, but I don't know how to advertise it.
We are free to change the contents of this jar at any minor/point release

@Randgalt Randgalt force-pushed the ZOOKEEPER-3703-publish-test-jar branch from 37fbcc8 to dbd4061 Compare January 21, 2020 21:39
@Randgalt Randgalt force-pushed the ZOOKEEPER-3703-publish-test-jar branch from dbd4061 to 54aaada Compare January 21, 2020 21:39
nkalmar
nkalmar approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@nkalmar nkalmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@maoling
Copy link
Member

maoling commented Feb 4, 2020

  • Yes, really needs this. I usually use curator-test for unit case test instead.
  • BTW, @nkalmar I saw your guys try to split the whole project into more modules: zookeeper-common, zookeeper-server, zookeeper-client previously. Any good news? :)

@eolivelli eolivelli closed this in 6db92d7 Feb 4, 2020
eolivelli pushed a commit that referenced this pull request Feb 4, 2020
@eolivelli
ZOOKEEPER-3703: publish a test JAR
3008ab7 
It would be very helpful to Apache Curator and others if ZooKeeper published its testing code as a Maven Test JAR. Curator, for example, could use it to improve its testing server to make it easier to inject error conditions without having to have forced time delays and other hacks.

NOTE: if we move forward with gRPC (ZOOKEEPER-102) that would be in a new module and this would be required. So, might as well do it now.

Author: Jordan Zimmerman <jordan@[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes #1229 from Randgalt/ZOOKEEPER-3703-publish-test-jar

(cherry picked from commit 6db92d7)
Signed-off-by: Enrico Olivelli <[email protected]>
eolivelli pushed a commit that referenced this pull request Feb 4, 2020
@eolivelli
ZOOKEEPER-3703: publish a test JAR
df37eb6 
It would be very helpful to Apache Curator and others if ZooKeeper published its testing code as a Maven Test JAR. Curator, for example, could use it to improve its testing server to make it easier to inject error conditions without having to have forced time delays and other hacks.

NOTE: if we move forward with gRPC (ZOOKEEPER-102) that would be in a new module and this would be required. So, might as well do it now.

Author: Jordan Zimmerman <jordan@[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes #1229 from Randgalt/ZOOKEEPER-3703-publish-test-jar

(cherry picked from commit 6db92d7)
Signed-off-by: Enrico Olivelli <[email protected]>
eolivelli pushed a commit that referenced this pull request Feb 4, 2020
@eolivelli
ZOOKEEPER-3703: publish a test JAR
e45b5a8 
It would be very helpful to Apache Curator and others if ZooKeeper published its testing code as a Maven Test JAR. Curator, for example, could use it to improve its testing server to make it easier to inject error conditions without having to have forced time delays and other hacks.

NOTE: if we move forward with gRPC (ZOOKEEPER-102) that would be in a new module and this would be required. So, might as well do it now.

Author: Jordan Zimmerman <jordan@[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes #1229 from Randgalt/ZOOKEEPER-3703-publish-test-jar

(cherry picked from commit 6db92d7)
Signed-off-by: Enrico Olivelli <[email protected]>
@eolivelli
Copy link
Contributor

@nkalmar I have cherry picked to branch-3.5 as this is the most active branch for users.
They will be able to use this facility in 3.5 and prepare for 3.6

junyoungKimGit pushed a commit to junyoungKimGit/zookeeper that referenced this pull request Feb 7, 2020
@junyoungKimGit
ZOOKEEPER-3703: publish a test JAR
f4d9a74 
It would be very helpful to Apache Curator and others if ZooKeeper published its testing code as a Maven Test JAR. Curator, for example, could use it to improve its testing server to make it easier to inject error conditions without having to have forced time delays and other hacks.

NOTE: if we move forward with gRPC (ZOOKEEPER-102) that would be in a new module and this would be required. So, might as well do it now.

Author: Jordan Zimmerman <jordan@[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1229 from Randgalt/ZOOKEEPER-3703-publish-test-jar
stickyhipp pushed a commit to stickyhipp/zookeeper that referenced this pull request Aug 19, 2020
@stickyhipp
ZOOKEEPER-3703: publish a test JAR
2ea3e28 
It would be very helpful to Apache Curator and others if ZooKeeper published its testing code as a Maven Test JAR. Curator, for example, could use it to improve its testing server to make it easier to inject error conditions without having to have forced time delays and other hacks.

NOTE: if we move forward with gRPC (ZOOKEEPER-102) that would be in a new module and this would be required. So, might as well do it now.

Author: Jordan Zimmerman <jordan@[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1229 from Randgalt/ZOOKEEPER-3703-publish-test-jar
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@RokLenarcic
ZOOKEEPER-3703: publish a test JAR
bd6a334 
It would be very helpful to Apache Curator and others if ZooKeeper published its testing code as a Maven Test JAR. Curator, for example, could use it to improve its testing server to make it easier to inject error conditions without having to have forced time delays and other hacks.

NOTE: if we move forward with gRPC (ZOOKEEPER-102) that would be in a new module and this would be required. So, might as well do it now.

Author: Jordan Zimmerman <jordan@[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1229 from Randgalt/ZOOKEEPER-3703-publish-test-jar
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@RokLenarcic
ZOOKEEPER-3703: publish a test JAR
21f38fa 
It would be very helpful to Apache Curator and others if ZooKeeper published its testing code as a Maven Test JAR. Curator, for example, could use it to improve its testing server to make it easier to inject error conditions without having to have forced time delays and other hacks.

NOTE: if we move forward with gRPC (ZOOKEEPER-102) that would be in a new module and this would be required. So, might as well do it now.

Author: Jordan Zimmerman <jordan@[email protected]>

Reviewers: Enrico Olivelli <[email protected]>, Norbert Kalmar <[email protected]>

Closes apache#1229 from Randgalt/ZOOKEEPER-3703-publish-test-jar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eolivelli eolivelli eolivelli approved these changes

@nkalmar nkalmar nkalmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Randgalt @maoling @eolivelli @nkalmar