fix shebang for deb/init.d/zookeeper #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztzg
pushed a commit
to ztzg/zookeeper
that referenced
this pull request
Nov 20, 2019
Fix issue using multiple hosts connection string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this (corrected) shebang, ZooKeeper will fail to start when installed via .deb packaging on Ubuntu because dash is invoked instead of bash and zkEnv.sh uses arrays which dash doesn't support.
Shout-out to satmd on freenode in #zookeeper for helping me troubleshoot.
Also a big -1 to relying on BigTop for packaging support.