-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ZOOKEEPER-2994. Refactor FileTxnLog's padding logic to separate class…
… for reusability
- Loading branch information
Showing
6 changed files
with
143 additions
and
102 deletions.
There are no files selected for viewing
105 changes: 105 additions & 0 deletions
105
src/java/main/org/apache/zookeeper/server/persistence/FilePadding.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.zookeeper.server.persistence; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import java.io.IOException; | ||
| import java.nio.ByteBuffer; | ||
| import java.nio.channels.FileChannel; | ||
|
|
||
| public class FilePadding { | ||
| private static final Logger LOG; | ||
| private static long preAllocSize = 65536 * 1024; | ||
| private static final ByteBuffer fill = ByteBuffer.allocateDirect(1); | ||
|
|
||
| static { | ||
| LOG = LoggerFactory.getLogger(FileTxnLog.class); | ||
|
|
||
| String size = System.getProperty("zookeeper.preAllocSize"); | ||
| if (size != null) { | ||
| try { | ||
| preAllocSize = Long.parseLong(size) * 1024; | ||
| } catch (NumberFormatException e) { | ||
| LOG.warn(size + " is not a valid value for preAllocSize"); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private long currentSize; | ||
|
|
||
| /** | ||
| * method to allow setting preallocate size | ||
| * of log file to pad the file. | ||
| * | ||
| * @param size the size to set to in bytes | ||
| */ | ||
| public static void setPreallocSize(long size) { | ||
| preAllocSize = size; | ||
| } | ||
|
|
||
| public void setCurrentSize(long currentSize) { | ||
| this.currentSize = currentSize; | ||
| } | ||
|
|
||
| /** | ||
| * pad the current file to increase its size to the next multiple of preAllocSize greater than the current size and position | ||
| * | ||
| * @param fileChannel the fileChannel of the file to be padded | ||
| * @throws IOException | ||
| */ | ||
| long padFile(FileChannel fileChannel) throws IOException { | ||
| long newFileSize = calculateFileSizeWithPadding(fileChannel.position(), currentSize, preAllocSize); | ||
| if (currentSize != newFileSize) { | ||
| fileChannel.write((ByteBuffer) fill.position(0), newFileSize - fill.remaining()); | ||
| currentSize = newFileSize; | ||
| } | ||
| return currentSize; | ||
| } | ||
|
|
||
| /** | ||
| * Calculates a new file size with padding. We only return a new size if | ||
| * the current file position is sufficiently close (less than 4K) to end of | ||
| * file and preAllocSize is > 0. | ||
| * | ||
| * @param position the point in the file we have written to | ||
| * @param fileSize application keeps track of the current file size | ||
| * @param preAllocSize how many bytes to pad | ||
| * @return the new file size. It can be the same as fileSize if no | ||
| * padding was done. | ||
| * @throws IOException | ||
| */ | ||
| // VisibleForTesting | ||
| public static long calculateFileSizeWithPadding(long position, long fileSize, long preAllocSize) { | ||
| // If preAllocSize is positive and we are within 4KB of the known end of the file calculate a new file size | ||
| if (preAllocSize > 0 && position + 4096 >= fileSize) { | ||
| // If we have written more than we have previously preallocated we need to make sure the new | ||
| // file size is larger than what we already have | ||
| if (position > fileSize) { | ||
| fileSize = position + preAllocSize; | ||
| fileSize -= fileSize % preAllocSize; | ||
| } else { | ||
| fileSize += preAllocSize; | ||
| } | ||
| } | ||
|
|
||
| return fileSize; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.