[ZEPPELIN-1312] Hotfix - consistent getNoteRevision in websocket call #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @corneadoug @bzz for review |
|
Looks good to me. @khalidhuseynov fix for version is not set in JIRA (neither it is assigned yet) - merging only to master after CI passes, in case there is no further discussion |
|
@bzz added fix version to issue. merging into master sounds good |
khalidhuseynov
force-pushed
the
hotfix/zeppelin-1312
branch
from
a14d71a to
d6b39ce
Compare
|
CI is green, so merging as a hotfix |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This pr fixes inconsistency on websocket call of getNoteRevision method on frontend, since backend waits for
Revisionbut front sendsRevisionId. This is the simplest fix without api change.What type of PR is it?
Hot Fix
Todos
RevisionId->RevisionWhat is the Jira issue?
Zeppelin-1312
How should this be tested?
CI pass
Screenshots (if appropriate)
Questions: