Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2896] [shim] Remove occupiedResource handling logic #927

Closed
wants to merge 1 commit into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Oct 16, 2024

What is this PR for?

Remove existing code related to occupiedResource.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2896

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.50%. Comparing base (753e4f8) to head (500dd49).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cache/context.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
- Coverage   68.62%   68.50%   -0.13%     
==========================================
  Files          70       70              
  Lines        7675     7607      -68     
==========================================
- Hits         5267     5211      -56     
+ Misses       2202     2189      -13     
- Partials      206      207       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko marked this pull request as draft October 16, 2024 12:52
@pbacsko pbacsko changed the title DRAFT [YUNIKORN-2896] [shim] Remove occupiedResource handling logic [YUNIKORN-2896] [shim] Remove occupiedResource handling logic Oct 17, 2024
@pbacsko pbacsko marked this pull request as ready for review October 17, 2024 13:59
@pbacsko pbacsko requested review from wilfred-s, chenyulin0719, craigcondit and manirajv06 and removed request for chenyulin0719 October 17, 2024 18:32
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants