[YUNIKORN-2135] Add integration test code coverage #733
Conversation
FrankYang0529
force-pushed
the
YUNIKORN-2135
branch
2 times, most recently
from
c3a62c7
to
470b53b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
==========================================
+ Coverage 69.43% 77.30% +7.86%
==========================================
Files 50 73 +23
Lines 7993 9284 +1291
==========================================
+ Hits 5550 7177 +1627
+ Misses 2254 1848 -406
- Partials 189 259 +70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
force-pushed
the
YUNIKORN-2135
branch
from
470b53b
to
3f1e58d
Compare
|
@FrankYang0529 could you resolve the merge conflicts? |
|
@FrankYang0529 can we write the logs to a directory under |
| @@ -87,7 +87,8 @@ function install_cluster() { | |||
| if [ "${GIT_CLONE}" = "true" ]; then | |||
| check_cmd "git" | |||
| rm -rf ./build/yunikorn-release | |||
| git clone --depth 1 https://github.com/apache/yunikorn-release.git ./build/yunikorn-release | |||
| # TODO: update following branch if PR in yunikorn-release is merged | |||
| git clone --depth 1 https://github.com/FrankYang0529/yunikorn-release.git -b YUNIKORN-2135 ./build/yunikorn-release | |||
There was a problem hiding this comment.
As indicated in the yunikorn-release repo PR, I think we should find a way to deploy this without polluting the upstream helm charts.
There was a problem hiding this comment.
Here's the approach we should use: https://helm.sh/docs/topics/advanced/#post-rendering
Helm supports a post-renderer that can be used to update the generated output. We can use this in the e2e test script during install to "patch" the installed charts with what is required here. An ideal post-renderer would be kustomize (see https://kustomize.io/). An example using the two together can be found here: https://github.com/thomastaylor312/advanced-helm-demos/tree/master/post-render
We can setup a kustomize script to patch only the objects we need so that the original helm charts can stay pristine. All that should be required is an ENV var and build-mount for /tmp/coverage (or something like it).
There was a problem hiding this comment.
@FrankYang0529 could you rebase the changes please? I'll come back to this once it can be merged.
What is this PR for?
If
ENABLE_GO_COVER_DIRisTRUE:uninstall_yunikornandcopy_go_cover_dirto run-e2e-tests.sh.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2135