Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow import of type systems published through SPI #385

Closed
reckart opened this issue Sep 4, 2024 · 0 comments
Closed

Allow import of type systems published through SPI #385

reckart opened this issue Sep 4, 2024 · 0 comments
Assignees
Labels
⭐️ Enhancement Improvement or new feature for users
Milestone

Comments

@reckart
Copy link
Member

reckart commented Sep 4, 2024

Is your feature request related to a problem? Please describe.
UIMA recently gained a mechanism to discovery JCas classes through an SPI. A similar mechanism for type system description discovery exists in uimaFIT. However, currently it is not possible to import from one TSD another TSD that has been discovered through the uimaFIT TSD SPI. This can cause exceptions.

Describe the solution you'd like
If a TSD has been (globally) published through the uimaFIT TSD SPI, it should also be importable.

Additional context
This is probably a good time to start merging uimaFIT into UIMA-J.

@reckart reckart added this to the 3.6.0 milestone Sep 4, 2024
@reckart reckart added the ⭐️ Enhancement Improvement or new feature for users label Sep 4, 2024
@reckart reckart self-assigned this Sep 26, 2024
reckart added a commit that referenced this issue Sep 26, 2024
- Enhance the Import_impl to look up descriptors via the type system description SPI
- Bit of cleaning up in related classes
reckart added a commit that referenced this issue Sep 26, 2024
reckart added a commit that referenced this issue Sep 27, 2024
- Consolidate the different provider interfaces into a TypeSystemProvider interface and provide an abstract base implementation with caching
reckart added a commit that referenced this issue Sep 30, 2024
- Deprecate current SPI interfaces in favor of the new combined interface
- Update documentation
- Consider the new combined interface in locations where we would previously only have considered the current interfaces
reckart added a commit that referenced this issue Sep 30, 2024
…systems-published-through-SPI

Issue #385: Allow import of type systems published through SPI
@reckart reckart closed this as completed Sep 30, 2024
reckart added a commit that referenced this issue Sep 30, 2024
- Added capabilities for the new unified provider
- Checking if a provider has already been processed when scanning legacy and new providers does not help because they are instantiated freshly on every call to the service provider scanner, so remove that
- Log different messages when loading through the legacy SPI interfaces and through the new one
reckart added a commit that referenced this issue Sep 30, 2024
…ystems-published-through-SPI

Issue #385: Allow import of type systems published through SPI
reckart added a commit that referenced this issue Oct 2, 2024
- Require specifying extension when initializing TypeSystemProvider_ImplBase
reckart added a commit that referenced this issue Oct 2, 2024
…s-as-thread-safe

Issue #385: Allow import of type systems published through SPI
reckart added a commit that referenced this issue Oct 4, 2024
- Take the CL of the resource manager into account when resolving the imports through SPIs
reckart added a commit that referenced this issue Oct 4, 2024
- Take the CL of the resource manager into account when resolving the imports through SPIs
reckart added a commit that referenced this issue Oct 4, 2024
- Take the CL of the resource manager into account when resolving the imports through SPIs
reckart added a commit that referenced this issue Oct 10, 2024
…ystems-published-through-SPI

Issue #385: Allow import of type systems published through SPI
@reckart reckart reopened this Nov 15, 2024
reckart added a commit that referenced this issue Nov 15, 2024
reckart added a commit that referenced this issue Nov 15, 2024
- Reduce how often the metaspace test creates a CAS
reckart added a commit that referenced this issue Nov 15, 2024
- Reduce how often the metaspace test creates a CAS
reckart added a commit that referenced this issue Nov 15, 2024
…systems-published-through-SPI

Issue #385: Allow import of type systems published through SPI
@reckart reckart closed this as completed Nov 15, 2024
reckart added a commit that referenced this issue Nov 15, 2024
* main:
  Issue #385: Allow import of type systems published through SPI
  Issue #385: Allow import of type systems published through SPI
reckart added a commit that referenced this issue Nov 21, 2024
* release/3.6.x: (805 commits)
  Issue #421: Apache UIMA Java SDK 3.6.0
  Issue #409: Update dependencies
  Issue #417: BOM should not inherit build setup from parent POM
  Issue #417: BOM should not inherit build setup from parent POM
  Issue #409: Update dependencies
  Issue #393: Include uimaFIT artifacts in binary distribution
  Issue #409: Update dependencies
  Issue #409: Update dependencies
  Issue #407: Clean up PearPackagingMavenPlugin
  Issue #385: Allow import of type systems published through SPI
  Issue #385: Allow import of type systems published through SPI
  No issue: Fix some typos
  Issue #404: Remove toolchains
  Issue #404: Remove toolchains
  No issue. Fix typo and add parent back to BOM
  Issue #402: Provide bnd plugin to generate package imports based on imports in UIMA descriptors
  Issue #402: Provide bnd plugin to generate package imports based on imports in UIMA descriptors
  Issue #385: Allow import of type systems published through SPI
  Issue #385: Allow import of type systems published through SPI
  Issue #398: Mark Maven plugins as thread-safe
  ...

% Conflicts:
%	PearPackagingMavenPlugin/pom.xml
%	aggregate-uimaj-eclipse-plugins/pom.xml
%	aggregate-uimaj/pom.xml
%	jVinci/pom.xml
%	jcasgen-maven-plugin/pom.xml
%	pom.xml
%	uimaj-adapter-vinci/pom.xml
%	uimaj-bom/pom.xml
%	uimaj-bootstrap/pom.xml
%	uimaj-component-test-util/pom.xml
%	uimaj-core/pom.xml
%	uimaj-cpe/pom.xml
%	uimaj-document-annotation/pom.xml
%	uimaj-documentation/pom.xml
%	uimaj-eclipse-feature-runtime/pom.xml
%	uimaj-eclipse-feature-tools/pom.xml
%	uimaj-eclipse-maven-p2-site/pom.xml
%	uimaj-eclipse-update-site/pom.xml
%	uimaj-ep-cas-editor-ide/pom.xml
%	uimaj-ep-cas-editor/pom.xml
%	uimaj-ep-configurator/pom.xml
%	uimaj-ep-debug/pom.xml
%	uimaj-ep-jcasgen/pom.xml
%	uimaj-ep-launcher/pom.xml
%	uimaj-ep-pear-packager/pom.xml
%	uimaj-ep-runtime/pom.xml
%	uimaj-examples/pom.xml
%	uimaj-json/pom.xml
%	uimaj-parent/pom.xml
%	uimaj-test-util/pom.xml
%	uimaj-tools/pom.xml
%	uimaj-v3migration-jcas/pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐️ Enhancement Improvement or new feature for users
Projects
None yet
Development

No branches or pull requests

1 participant