Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper annotation created by subiterator may remain in CAS #346

Closed
reckart opened this issue Sep 18, 2023 · 0 comments
Closed

Helper annotation created by subiterator may remain in CAS #346

reckart opened this issue Sep 18, 2023 · 0 comments
Assignees
@reckart
Labels
🦟 Bug Something isn't working
Milestone
3.5.0

Comments

@reckart
Copy link
Member

reckart commented Sep 18, 2023

Describe the bug
If the UIMA-v2 mode that retains references to all created annotations is active, then the temporary annotations created by the Subiterator class remain in the CAS.

Expected behavior
When creating a temporary annotation, the creation should be guarded by a try/catch that temporarily turns off the UIMA-v2 mode.

Please complete the following information:

  • Version: 3.4.1
@reckart reckart added the 🦟 Bug Something isn't working label Sep 18, 2023
@reckart reckart added this to the 3.5.0 milestone Sep 18, 2023
@reckart reckart self-assigned this Sep 18, 2023
reckart added a commit that referenced this issue Sep 18, 2023
@reckart
Issue #346: Helper annotation created by subiterator may remain in CAS
3c8c85a 
- Use internal helper method from SelectFSs_impl to produce temporary annotation
- Clean up test class
reckart added a commit that referenced this issue Sep 18, 2023
@reckart
Issue #346: Helper annotation created by subiterator may remain in CAS
6347db2 
- Use internal helper method from SelectFSs_impl to produce temporary annotation
- Clean up test class
reckart added a commit that referenced this issue Sep 19, 2023
@reckart
Merge pull request #347 from apache/bugfix/346-Helper-annotation-crea…
e9e16c2 
…ted-by-subiterator-may-remain-in-CAS

Issue #346: Helper annotation created by subiterator may remain in CAS
@reckart reckart closed this as completed Sep 19, 2023
reckart added a commit that referenced this issue Sep 19, 2023
@reckart
Merge branch 'main' into refactoring/350-Clean-up-and-modernize-code
10af8cc 
* main:
  Issue #346: Helper annotation created by subiterator may remain in CAS

% Conflicts:
%	uimaj-core/src/test/java/org/apache/uima/cas/test/SubiteratorTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🦟 Bug Something isn't working
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
1 participant
@reckart