-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QNN] Add qnn.rsqrt op #9982
[QNN] Add qnn.rsqrt op #9982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a more concrete comment on the design decision for canonicalizing to fp32 and possible future workarounds, but otherwise, a quick overview looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , but one comment
e2c8db6
to
a9333ba
Compare
Probably just need to rebase on main after 589fc01 The CI failure does not seem to be the fault of the PR |
a9333ba
to
246ea29
Compare
* Add qnn.rsqrt op * Add comment
* Add qnn.rsqrt op * Add comment
Add QNN op for reciprocal sqrt, the default legalization goes through dequantize->rsqrt->quantize