[Fix] relay onnx frontend bug when [A, B, M, N] * [1, B, N, K] #9911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willzhang4a58
requested review from
Huyuwei,
jwfromm,
kazum,
mbrookhart,
siju-samuel and
srkreddy1238
as code owners
willzhang4a58
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen and
yzhliu
as code owners
|
Fix BUG and add test case for batch_matmul [A, B, M, N] * [1, B, N, K] |
|
Will take a look later today |
python/tvm/relay/frontend/onnx.py
Outdated
| [ | ||
| out_batch, | ||
| _op.strided_slice( | ||
| a_shape, [infer_shape(a_shape)[0] - 2], [infer_shape(a_shape)[0]] |
There was a problem hiding this comment.
nit: use a_rank instead of infer_shape(a_shape)[0]
AndrewZhaoLuo
approved these changes
Jan 14, 2022
python/tvm/relay/frontend/onnx.py
Outdated
| [ | ||
| out_batch, | ||
| _op.strided_slice( | ||
| b_shape, [infer_shape(b_shape)[0] - 2], [infer_shape(b_shape)[0]] |
There was a problem hiding this comment.
same here, use b_rank
|
hi @AndrewZhaoLuo , I have fixed the comment. |
crazydemo
pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
…e#9911) * [Fix] relay onnx frontend bug when [A, B, M, N] * [1, B, N, K] * fix line Co-authored-by: tomoyazhang <[email protected]>
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
…e#9911) * [Fix] relay onnx frontend bug when [A, B, M, N] * [1, B, N, K] * fix line Co-authored-by: tomoyazhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.