[BugFix] Fix a wrong use of std::move() in cross-thread reduction lowering
#9728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterJH5574
requested review from
Hzfengsy,
junrushao,
kparzysz-quic,
masahi,
tqchen,
vinx13 and
ZihengJiang
as code owners
|
Looks like I triggered an undefined behavior of C++ 🥺 |
junrushao
approved these changes
Dec 13, 2021
|
😂 Given the undefined behavior of evaluation order, we decided to remove the |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
…owering (apache#9728) * [BugFix] Fix a wrong use of `std::move()` in cross-thread reduction lowering * Remove
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 11, 2022
…owering (apache#9728) * [BugFix] Fix a wrong use of `std::move()` in cross-thread reduction lowering * Remove
yangulei
pushed a commit
to yangulei/tvm
that referenced
this pull request
Jan 12, 2022
…owering (apache#9728) * [BugFix] Fix a wrong use of `std::move()` in cross-thread reduction lowering * Remove
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…owering (apache#9728) * [BugFix] Fix a wrong use of `std::move()` in cross-thread reduction lowering * Remove
qsqqsqqsq-intellif
pushed a commit
to qsqqsqqsq-intellif/tvm
that referenced
this pull request
Apr 29, 2022
…owering (apache#9728) * [BugFix] Fix a wrong use of `std::move()` in cross-thread reduction lowering * Remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find a wrong use of
std::move(). Please see the changes for detail. The wrong use leads to undefined Var of a buffer'sdatafield.Given C++ evaluates parameter expressions from the end to the beginning, we should use
std::moveat the first occurrence, instead of the last.cc @junrushao1994 @Hzfengsy