Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Windows and MacOS GitHub Actions #9578

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

driazati
Copy link
Member

@driazati driazati commented Nov 24, 2021

Previously these were in one workflow with ifs on every step after some common setup. This pulls out the common stuff into a local action and makes macos and windows builds completely separate, removing the need for any ifs to skip steps so everything looks little cleaner. This also has some minor cleanups:

  • use submodules: recursive on actions/checkout to avoid manually getting submodules
  • add a concurrency key so that pushes that happen before the job is finished cancel previously running jobs on the same PR

@areusch @tqchen

@driazati driazati marked this pull request as ready for review November 24, 2021 20:32
@driazati driazati requested a review from a team as a code owner November 24, 2021 20:32
Copy link
Member

@jroesch jroesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me, we can continue to iterate on this.

@jroesch jroesch merged commit 7e673f8 into apache:main Nov 29, 2021
masahi pushed a commit to masahi/tvm that referenced this pull request Dec 1, 2021
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 12, 2022
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants