Implement [skip ci] for Jenkins #9554

driazati · 2021-11-23T00:41:21Z

GitHub Actions already respects this (link), this implements it for Jenkins as well. When [skip ci] is in the commit message of the head commit and in the PR title, the only things that will run are the sanity check + lint, so CI should be much quicker if someone manually sets this.

This is useful for PRs that need to get landed quickly and the outcome is pretty well known, such as reverts (and should only be used in these situations). Tested in #9686

Also see the related forum discussion: https://discuss.tvm.apache.org/t/rfc-ci-add-a-skip-ci-tag-to-shortcut-builds-and-tests/11589/10

@areusch

leandron · 2021-11-23T23:18:08Z

tests/scripts/git_skip_ci.sh

+# headline
+
+if git log --format='%s' HEAD~1..HEAD | grep --quiet \
+    --regexp='\[skip ci\]' \


As this is something new we are introducing, we could start with only one documented pattern rather than all these option variants, which makes a bit harder to manually grep on which commits in history didn’t run a full CI.

I am also a bit concerned on how we make sure that only exceptional changes that don’t really need CI will make use of this. As an extension, I wonder if Jenkins could somehow tag the PR with something when it detects the “skip ci” tag, so that it is obvious for reviewers that this didn’t run any checks, apart from lint.

Any idea on how to tackle these?

Agreed on consolidating on a single trigger message like [skip ci] for now. At some level we'd need to rely on committers / mergers knowing that [skip ci] should only be applied to quick fixes and reverts to unbreak master which seems do-able. We could make it easier to tell without clicking by add a label like CI was skipped to the PR (through GitHub Actions or (ideally) directly from Jenkins)

Agreed. To me, that is a must to have this PR in.

Another point, just to mention, is that we ideally would like to document it somewhere, so that it is clear for the community this is available and how to use it.

areusch · 2021-11-24T02:58:31Z

couple thoughts:

i think we should add unit tests for something like this so we can be sure it works correctly. it would be great to consider the cases of:
- main has [skip ci] commit
- PR branch has [skip ci] commit
- no [skip ci] commit exists
we might consider submitting this for RFC considering as it's a change to the development process.

i'm also curious about @leandron's comment about flagging skipped PRs.

shingjan · 2021-12-03T07:17:11Z

Jenkinsfile

+          script: './tests/scripts/git_skip_ci.sh',
+          label: "Check if CI should be skipped",
+        )
+        // if (skip_ci == 1) {


Should these comments be removed as they are duplicated below?

sorry this was some work-in-progress code, I should have marked this as a draft since I'm still working on implementing the PR labeling aspect

driazati · 2021-12-09T20:27:32Z

There are some test usages here showing how skip is triggered (i.e. the CI on the first commit in that PR takes only a few minutes): #9686

areusch

one question here--also, we should push this to ci-docker-staging one final time i think. just checking that makes sense to you?

areusch · 2021-12-13T19:05:43Z

tests/python/unittest/test_ci.py

+            ["commit", "--allow-empty", "--message", "[skip ci] commit 1"],
+        ],
+        should_skip=True,
+        why="ci should be skipped on a branch with [skip ci] in the last commit",


do we have a test for when [skip ci] is in a commit but not in PR title? i don't think we should allow only the commit to have [skip ci]

added one in 0710915

driazati · 2021-12-13T19:18:39Z

Confirming sounds good, it should be ready to push now

areusch · 2022-01-12T20:52:19Z

looks like the branch failed due to a flaky test. given passing tests linked from #9686, i think we can merge and be confident we aren't going to break the Jenkinsfile

This reverts commit 9d867c2. Note: This PR is a test of the skip CI functionality from apache#9554. It was made with: ```bash git checkout -b revert_test git revert HEAD gh pr create --draft ```

This was inadvertently removed by apache#9554

This was inadvertently removed by #9554 Co-authored-by: driazati <[email protected]>

* Rebase * Fix missing skip Co-authored-by: driazati <[email protected]>

This was inadvertently removed by apache#9554 Co-authored-by: driazati <[email protected]>

* Rebase * Fix missing skip Co-authored-by: driazati <[email protected]>

This was inadvertently removed by apache#9554 Co-authored-by: driazati <[email protected]>

* Rebase * Fix missing skip Co-authored-by: driazati <[email protected]>

This was inadvertently removed by apache#9554 Co-authored-by: driazati <[email protected]>

driazati force-pushed the driazati/test_skip branch from ac20f37 to 46b956c Compare November 23, 2021 05:59

driazati marked this pull request as ready for review November 23, 2021 17:38

driazati requested review from areusch, comaniac, icemelon, jroesch, junrushao, merrymercy, tqchen, yzhliu and a team as code owners November 23, 2021 17:38

leandron reviewed Nov 23, 2021

View reviewed changes

driazati force-pushed the driazati/test_skip branch 2 times, most recently from b68189a to b980b76 Compare November 25, 2021 05:52

driazati force-pushed the driazati/test_skip branch from b980b76 to e93a905 Compare December 2, 2021 23:32

shingjan reviewed Dec 3, 2021

View reviewed changes

driazati marked this pull request as draft December 3, 2021 21:17

driazati force-pushed the driazati/test_skip branch 11 times, most recently from af98484 to 1c3b526 Compare December 9, 2021 00:50

driazati marked this pull request as ready for review December 9, 2021 20:27

driazati mentioned this pull request Dec 9, 2021

[skip ci][do not merge] Test Skip CI #9686

Closed

areusch reviewed Dec 13, 2021

View reviewed changes

driazati force-pushed the driazati/test_skip branch 2 times, most recently from 387183e to 1c47808 Compare December 16, 2021 00:14

driazati force-pushed the driazati/test_skip branch from 1c47808 to b48f47b Compare January 3, 2022 20:18

Rebase

d7b0cce

driazati force-pushed the driazati/test_skip branch from b48f47b to d7b0cce Compare January 11, 2022 20:19

Fix missing skip

b81a0ad

areusch approved these changes Jan 12, 2022

View reviewed changes

areusch merged commit 586944e into apache:main Jan 12, 2022

This was referenced Jan 12, 2022

[skip ci] Revert "[community] @AndrewZhaoLuo -> Committer (#9896)" #9916

Closed

[skip ci] Fix missing pack_lib in Jenkinsfile #9924

Merged

driazati added a commit to driazati/tvm that referenced this pull request Jan 13, 2022

[skip ci] Fix missing pack_lib in Jenkinsfile

7b39efd

This was inadvertently removed by apache#9554

jroesch pushed a commit that referenced this pull request Jan 13, 2022

[skip ci] Fix missing pack_lib in Jenkinsfile (#9924)

2c1ed59

This was inadvertently removed by #9554 Co-authored-by: driazati <[email protected]>

crazydemo pushed a commit to crazydemo/tvm that referenced this pull request Jan 27, 2022

Implement [skip ci] for Jenkins (apache#9554)

6f8b498

* Rebase * Fix missing skip Co-authored-by: driazati <[email protected]>

crazydemo pushed a commit to crazydemo/tvm that referenced this pull request Jan 27, 2022

[skip ci] Fix missing pack_lib in Jenkinsfile (apache#9924)

d11a2e8

This was inadvertently removed by apache#9554 Co-authored-by: driazati <[email protected]>

Raghav-Chakravarthy pushed a commit to Raghav-Chakravarthy/tvm that referenced this pull request Jan 28, 2022

Implement [skip ci] for Jenkins (apache#9554)

fa3db25

* Rebase * Fix missing skip Co-authored-by: driazati <[email protected]>

Raghav-Chakravarthy pushed a commit to Raghav-Chakravarthy/tvm that referenced this pull request Jan 28, 2022

[skip ci] Fix missing pack_lib in Jenkinsfile (apache#9924)

73fa34e

This was inadvertently removed by apache#9554 Co-authored-by: driazati <[email protected]>

ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022

Implement [skip ci] for Jenkins (apache#9554)

81815a1

* Rebase * Fix missing skip Co-authored-by: driazati <[email protected]>

ylc pushed a commit to ylc/tvm that referenced this pull request Feb 16, 2022

[skip ci] Fix missing pack_lib in Jenkinsfile (apache#9924)

4323522

This was inadvertently removed by apache#9554 Co-authored-by: driazati <[email protected]>

driazati mentioned this pull request Jul 14, 2022

TVM v0.9.0.rc0 Release Candidate Notes #12102

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement [skip ci] for Jenkins #9554

Implement [skip ci] for Jenkins #9554

driazati commented Nov 23, 2021 •

edited

Loading

leandron Nov 23, 2021

driazati Nov 24, 2021

leandron Nov 25, 2021

areusch commented Nov 24, 2021

shingjan Dec 3, 2021

driazati Dec 3, 2021

driazati commented Dec 9, 2021

areusch left a comment

areusch Dec 13, 2021

driazati Dec 13, 2021

driazati commented Dec 13, 2021

areusch commented Jan 12, 2022

Implement [skip ci] for Jenkins #9554

Implement [skip ci] for Jenkins #9554

Conversation

driazati commented Nov 23, 2021 • edited Loading

leandron Nov 23, 2021

Choose a reason for hiding this comment

driazati Nov 24, 2021

Choose a reason for hiding this comment

leandron Nov 25, 2021

Choose a reason for hiding this comment

areusch commented Nov 24, 2021

shingjan Dec 3, 2021

Choose a reason for hiding this comment

driazati Dec 3, 2021

Choose a reason for hiding this comment

driazati commented Dec 9, 2021

areusch left a comment

Choose a reason for hiding this comment

areusch Dec 13, 2021

Choose a reason for hiding this comment

driazati Dec 13, 2021

Choose a reason for hiding this comment

driazati commented Dec 13, 2021

areusch commented Jan 12, 2022

driazati commented Nov 23, 2021 •

edited

Loading