-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microNPU] Support binary elementwise with non-4D inputs #9521
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should codegen test few more special cases, but otherwise looks really good! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @ekalda!
Reshapes non-4D inputs to become 4D, then reshapes the output back to the non-4D input shape. Change-Id: I680ac06841aa1323435bcd09b6996fc57117cd84
Change-Id: I5bae1bd11fa0c82e3ffd882fddfcb925dff259cb
Change-Id: I6167cf73b2722902212717c5243cd19edc3489b7
1291cea
to
8e4a152
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @lhutton1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :) Thanks @lhutton1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! @lhutton1 @NicolaLancellotti @ekalda |
Reshapes non-4D inputs to become 4D, then reshapes the output back to the non-4D input shape.
Reshapes non-4D inputs to become 4D, then reshapes the output back to the non-4D input shape.
Reshapes non-4D inputs to become 4D, then reshapes the output back to the non-4D input shape.
Reshapes non-4D inputs to become 4D, then reshapes the output back to the non-4D input shape.
Reshapes non-4D inputs to become 4D, then reshapes the output back to the non-4D input shape.
Reshapes non-4D inputs to become 4D, then reshapes the output back to the non-4D input shape.
Reshapes non-4D inputs to become 4D, then reshapes the output back to the non-4D input shape.
Reshapes non-4D inputs to become 4D, then reshapes the output back to the non-4D input shape after selected binary elementwise operation is performed.
cc @ekalda @NicolaLancellotti @manupa-arm @dchauhan-arm