Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR][LowerMatchBuffer] Fix lowering strides when source region has higher dimension than the buffer #9145

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

vinx13
Copy link
Member

@vinx13 vinx13 commented Sep 28, 2021

This PR fixed a bug in lowering strides when source region has higher dimension than the buffer. Also fixed printing error message in checking elem_offset by using the value used in Bind (instead of the variable buffer->elem_offset)

@Hzfengsy

@vinx13 vinx13 force-pushed the fix/lower_match_buffer branch from 0e5d8a6 to a15b990 Compare September 28, 2021 21:47
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@vinx13 vinx13 merged commit da5b4fb into apache:main Sep 29, 2021
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 30, 2021
* main: (80 commits)
  Introduce centralised name transformation functions (apache#9088)
  [OpenCL] Add vectorization to cuda conv2d_nhwc schedule (apache#8636)
  [6/6] Arm(R) Ethos(TM)-U NPU codegen integration with `tvmc` (apache#8854)
  [microTVM] Add wrapper for creating project using a MLF (apache#9090)
  Fix typo (apache#9156)
  [Hotfix][Testing] Wait for RPCServer to be established (apache#9150)
  Update find cublas so it search default path if needed. (apache#9149)
  [TIR][LowerMatchBuffer] Fix lowering strides when source region has higher dimension than the buffer (apache#9145)
  Fix flaky NMS test by making sure scores are unique (apache#9140)
  [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc (apache#9038)
  [LLVM] Make changes needed for opaque pointers (apache#9138)
  Arm(R) Ethos(TM)-U NPU codegen integration (apache#8849)
  [CI] Split Integration tests out of first phase of pipeline (apache#9128)
  [Meta Schedule][M3b] Runner (apache#9111)
  Fix Google Mock differences between Ubuntu 18.04 and 16.04 (apache#9141)
  [TIR] add loop partition hint pragma (apache#9121)
  fix things (apache#9146)
  [Meta Schedule][M3a] SearchStrategy (apache#9132)
  [Frontend][PyTorch] support for quantized conv_transpose2d op (apache#9133)
  [UnitTest] Parametrized test_conv2d_int8_intrinsics (apache#9143)
  ...
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
…igher dimension than the buffer (apache#9145)

* [TIR][LowerMatchBuffer] Fix lowering strides when source region has higher dimension than the buffer

* use int instead of size_t
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
…igher dimension than the buffer (apache#9145)

* [TIR][LowerMatchBuffer] Fix lowering strides when source region has higher dimension than the buffer

* use int instead of size_t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants