[PYTHON][FFI] Skip numpy.ascontiguousarray if C_CONTIGUOUS == True #9073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, i just run a tensorflow model with TVM. My model has 321 inputs so i find create NDArray inputs for model is time consuming.
Code:
is used in function NDArray.copyfrom when create NDArray from Numpy. I find this code cost 0.47ms for my model, but a numpy array without operation like slice is contiguous and ascontiguousarray is not needed. In fact this code do nothing in my case, but 0.47ms is used.
So i add a type check, and i use a table DataType.NUMPY2STR to avoid str(np.dtype) as i find it time comusing, as i do in commit: #9072