Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when compile tvm with latest llvm14git #8682

Merged
merged 4 commits into from
Aug 8, 2021

Conversation

Joejiong
Copy link
Contributor

@Joejiong Joejiong commented Aug 7, 2021

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

Fix two compilation error when compile tvm with latest llvm when version >=12;

@junrushao
Copy link
Member

Thanks for the fix! I am not the expert of the LLVM backend, so CC’ing related experts @kparzysz-quic @FrozenGene @zhiics

@Joejiong
Copy link
Contributor Author

Joejiong commented Aug 7, 2021

Thanks for the fix! I am not the expert of the LLVM backend, so CC’ing related experts @kparzysz-quic @FrozenGene @zhiics

your CI got some problem with latest llvm, clearly, the following two things have changed for a while.

the problem happens when you build your own llvm and change the cmake.config pointing to the /latest/path/to/llvm-config, then you will get several compilation errors.

@junrushao
Copy link
Member

To keep backward compatibility with earlier LLVM distributions, please use macros to guard the code path. Thanks :-)

@Joejiong
Copy link
Contributor Author

Joejiong commented Aug 8, 2021

earlier

thx, ok, sorry didn't see the surrounding examples, hahaha~

@tqchen tqchen merged commit babaa74 into apache:main Aug 8, 2021
@tqchen
Copy link
Member

tqchen commented Aug 8, 2021

Thank you @Joejiong !

mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Aug 11, 2021
@deeply
Copy link

deeply commented Sep 13, 2021

Seems that llvm-13 has already changed the signature of llvm::Intrinsic::getName in the latest rc2. Maybe we need to update the guard macro to #if TVM_LLVM_VERSION <= 120 for calling llvm::Intrinsic::getName? 😄

ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants