-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of docker/lint.sh clang_format with git-worktree #8639
Conversation
@areusch let us do a quick check in case some of the CI might depend on the /workspace behavior |
@tqchen last time it was the rust rebuild which is conveniently disabled now :) |
not that i am trying to actively break rust but i don't understand the build system enough to know how to fix it and last time the PR languished forever and died because no one was willing to help. |
* properly quote command-line arguments * mount repo at $(pwd) by default; fixes problems when using git-worktree.
9050f57
to
339ebda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* mount repo at $(pwd) by default; fixes problems when using git-worktree.
What is the problem when using git-worktree? I'm not very familiar with it.
* allows usage of docker/lint.sh with arbitrary tvm repo
Maybe we could add a "usage" example in the header of the script, to instruct people on how to do that?
Also, a bit off topic for here but I think we really should think about processing the inputs in a loop so that users can provide non-positional parameters in any order.
docker/bash.sh
Outdated
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
WORKSPACE="$(pwd)" | ||
|
||
if [ "$1" == "--repo-mount-point" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to add this on line 23 small documentation to the command line, also to show the order in which parameters need to be provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@leandron try running
ack
will see if i can do this in next patch |
superseded by #8670 |
cc @jroesch @mikepapadim @tqchen