[TOPI] Fix nn.pool*d issue with 'vectorize' function and add unit tests
#8541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioPeric-SiMa-ai
requested review from
areusch,
comaniac,
Huyuwei,
jcf94,
jroesch,
junrushao,
jwfromm,
kevinthesun,
Laurawly,
masahi,
mbrookhart,
merrymercy,
tqchen,
vinx13,
yzhliu and
ZihengJiang
as code owners
comaniac
approved these changes
Jul 23, 2021
jcf94
changed the title
nn.pool*d issue with 'vectorize' function and add unit tests
jcf94
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Thanks! @MarioPeric-SiMa-ai There're still some CI issues in thi PR need to be fixed, I think we can merge this once CI has been cleaned.
|
@jcf94 I've fixed issues with linter, but I'm not sure what's wrong now. |
Oh, I think that's not your fault. Seems recently we got some trouble with the CI machine. I also have several PRs blocked by the CI issue. Related: #8552 |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…ests (apache#8541) * Fix issue in 'vectorize' function for 1D and 3D tensors * Add pooling tests for channel last layouts * Add support for more general layouts in "poolnd" implementation * Reformat with 'black' * Fix lint issues
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
…ests (apache#8541) * Fix issue in 'vectorize' function for 1D and 3D tensors * Add pooling tests for channel last layouts * Add support for more general layouts in "poolnd" implementation * Reformat with 'black' * Fix lint issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the issue that is preventing 1D and 3D pooling functions to be used with non-default layouts on x86 architecture. Unit tests were added as well to confirm that this is working since there were not test to cover this case.