[Unittests] Added a meta-test for tvm.testing.fixture behavior in case of a broken fixture. #8343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areusch
reviewed
Jun 28, 2021
| def test_uses_broken_cached_fixture(self, broken_cached_fixture): | ||
| type(self).num_uses_broken_cached_fixture += 1 | ||
|
|
||
| def test_num_uses_cached(self): |
There was a problem hiding this comment.
if we parallelize testing, will this inter-test dependency work?
There was a problem hiding this comment.
Currently, it will not. We'd need to also add a call to pytest_xdist_make_scheduler (example stack overflow post) in order to force these tests to be run in order on a single node.
There was a problem hiding this comment.
As mentioned in our conversation yesterday, I've added a comment regarding pytest-xdist and the link to the above stackoverflow post to this PR, so that it will be easier to find if/when we parallelize the testing.
There was a problem hiding this comment.
this seems like a reasonably easy thing to do. thanks @Lunderberg !
…e of a broken fixture. In these cases, the test function should be marked as failing the setup, and should not run. This is pytest's default behavior, and should work whether or not a fixture is cached.
Lunderberg
force-pushed
the
tvm_testing_broken_fixture
branch
from
b0b0551 to
770ebc1
Compare
areusch
approved these changes
Jun 29, 2021
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
…e of a broken fixture. (apache#8343) In these cases, the test function should be marked as failing the setup, and should not run. This is pytest's default behavior, and should work whether or not a fixture is cached. Co-authored-by: Eric Lunderberg <[email protected]>
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Mar 4, 2022
…e of a broken fixture. (apache#8343) In these cases, the test function should be marked as failing the setup, and should not run. This is pytest's default behavior, and should work whether or not a fixture is cached. Co-authored-by: Eric Lunderberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these cases, the test function should be marked as failing the setup, and should not run. This is pytest's default behavior, and should work whether or not a fixture is cached.