[Logging] Bring back the stack size optimization #7756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back the stack size optimization:
dmlc::LogMessageFatal
to the heap dmlc/dmlc-core#613DMLC_NO_INLINE
toLogMessageFatal
dmlc/dmlc-core#615It also brings back the error message showing those numbers used in comparison "(1 vs 2)" when
CHECK_XX
fails.Some tricks:
LogFatal
an empty class, storing data on TLS so that it doesn't occupy stack spaceI tested the stack size in the following setting:
The stack usage drops from 1392 to 496 with the aforementioned tricks.
CC @comaniac @tkonolige @tqchen. Please let me know if it solves #7729. Thanks in advance!