[Relay][PatternLang] Bug fix of rewrite func attr #7358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using pattern with attr of functions, such attrs mostly does not exist for op node. Therefore, hasattr check has to be done for op nodes. Change-Id: Ia313ab34be95ccc793c32fd8e5e5ef566b78685b
manupak
force-pushed
the
pattern_matcher_func_attr_bugfix
branch
from
4932e24 to
14fc1e2
Compare
masahi
approved these changes
Jan 28, 2021
mbrookhart
approved these changes
Jan 28, 2021
|
Thanks for finding this @manupa-arm ! |
|
Thanks @manupa-arm @masahi |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
When using pattern with attr of functions, such attrs mostly does not exist for op node. Therefore, hasattr check has to be done for op nodes. Change-Id: Ia313ab34be95ccc793c32fd8e5e5ef566b78685b
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
When using pattern with attr of functions, such attrs mostly does not exist for op node. Therefore, hasattr check has to be done for op nodes. Change-Id: Ia313ab34be95ccc793c32fd8e5e5ef566b78685b
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
When using pattern with attr of functions, such attrs mostly does not exist for op node. Therefore, hasattr check has to be done for op nodes. Change-Id: Ia313ab34be95ccc793c32fd8e5e5ef566b78685b
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
When using pattern with attr of functions, such attrs mostly does not exist for op node. Therefore, hasattr check has to be done for op nodes. Change-Id: Ia313ab34be95ccc793c32fd8e5e5ef566b78685b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using pattern with attr of functions, such attrs mostly does not exist for op node. Therefore, hasattrcheck has to be done for op nodes.
@mbrookhart @masahi @comaniac