Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] add python environment setup as part of cpp unittest runner script #6639

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[CI] add python environment setup as part of cpp unittest runner script #6639

merged 1 commit into from
Oct 6, 2020

Conversation

leandron
Copy link
Contributor

@leandron leandron commented Oct 6, 2020

In #6334, task_cpp_unittest.sh script started also running apps/bundle_deploy's test_dynamic and test_static. If now we try to run task_cpp_unittest.sh as a standalone script, we'll see an error complaining it can't find tvm python module.

The error message is:

(...)
[==========] Running 0 tests from 0 test cases.
[==========] 0 tests from 0 test cases ran. (0 ms total)
[  PASSED  ] 0 tests.
python3 build_model.py -o build --test
Traceback (most recent call last):
  File "build_model.py", line 21, in <module>
    from tvm import relay
ModuleNotFoundError: No module named 'tvm'
Makefile:123: recipe for target 'build/test_graph_c.json' failed
make: *** [build/test_graph_c.json] Error 1

This PR adds the python environment setup script to have TVM's python environment setup available, to make task_cpp_unittest.sh runs as a standalone script.

We don't see this error in the current upstream CI, because we always run the build script before cpp tests, and in this case we'll be in the right directory when this test runs.

cc @areusch @tqchen

@tqchen tqchen merged commit 0cfda17 into apache:master Oct 6, 2020
@leandron leandron deleted the cpp_tests_python_dep branch October 7, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants