-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Torch] Clean up usage of try ... infer_value() ... except #6504
Conversation
@tqchen I got a build error from utvm crt https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-6504/2/pipeline I don't understand why I'm getting an error from a file like |
94f4627
to
e6094fe
Compare
Yeah, I'm seeing the same on my PR as well. |
@masahi was due to a cmake cache problem that PR has been merged, please retrigger. |
e6094fe
to
9ac55ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @kevinthesun @yongwww |
* clean up infer value usage * try silence pylint * remove unused variable * make on_failuare optional * make on_success optional True Co-authored-by: masa <[email protected]>
* clean up infer value usage * try silence pylint * remove unused variable * make on_failuare optional * make on_success optional True Co-authored-by: masa <[email protected]>
* clean up infer value usage * try silence pylint * remove unused variable * make on_failuare optional * make on_success optional True Co-authored-by: masa <[email protected]>
* clean up infer value usage * try silence pylint * remove unused variable * make on_failuare optional * make on_success optional True Co-authored-by: masa <[email protected]>
* clean up infer value usage * try silence pylint * remove unused variable * make on_failuare optional * make on_success optional True Co-authored-by: masa <[email protected]>
This is a follow up to #6449 where some usage of exception-throwing
infer_value
is introduced. Following the discussion there, I attempted to clean up that usage with a new wrapper API. I think this is a reasonable change to add.The following API is added. If this looks good, I'll add a doc string. See the example use in the Torch frontend.
please review @kevinthesun @t-vi @siju-samuel