Switch CRC-CCITT libraries #6499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subtree-dir: 3rdparty/libcrc git-subtree-split: b5e4186d7ab63458e79084842dced166be2ca5b5
|
cc @tqchen |
tqchen
approved these changes
Sep 16, 2020
|
@areusch the vta-hw update might be unintended, please use git submodule update to point to the upstream code |
|
ugh, fixed |
cbalint13
requested changes
Sep 17, 2020
There was a problem hiding this comment.
Wouldn't be better to use BOOST's crc or LLVM's crc?
(1) Boost's crc (16-bit, extensive types):
- https://www.boost.org/doc/libs/1_74_0/doc/html/crc.html
- https://stackoverflow.com/questions/36732949/boost-crc-16-bit
We could only add boost detection to actual cmake flow and just use it.
(2) LLVM's crc (32-bit variant only):
- See header /usr/include/llvm/Support/CRC.h
LLVM is already involved, we can directly use getCRC() function.
|
Thansk @cbalint13 I believe the main concern here is the need for a minimum C impl for micro controllers, so boost/llvm cannot be used in this case. Although the most ideal case might be a mininum impl in the uTVM source. I am going to merge this for now. |
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6496.
I found an MIT-licensed library that was fairly easy to adapt, but I had to make some changes on top of the pristine import. I feel like we normally use submodule, but given changes were needed, imported with subtree and patched on top. let me know if you prefer a different approach.