[RELAY][DYN] Dynamic UpSampling3D Op #6353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@mbrookhart @zhiics can you please follow up |
mbrookhart
approved these changes
Sep 3, 2020
zhiics
reviewed
Sep 3, 2020
| func = relay.Function([x, scale_d_var, scale_h_var, scale_w_var], z) | ||
|
|
||
| for target, ctx in ctx_list(): | ||
| ##TODO(mbrookhart)(electriclilies): remove when VM supports heterogeneous execution |
zhiics
reviewed
Sep 3, 2020
| verify_upsampling((1, 16, 32, 32), 2.0, 2.0,"NCHW", "nearest_neighbor") | ||
| verify_upsampling((1, 16, 32, 32), 2.0, 2.0, "NCHW", "bilinear", True) | ||
| verify_upsampling((1, 16, 32, 32), 2.0, 2.0, "NHWC", "nearest_neighbor") | ||
| ##TODO(mbrookhart)(electriclilies): remove when VM supports heterogeneous execution |
There was a problem hiding this comment.
ctx_list has been removed. Use enabled_targets and we can enable GPU tests now
zhiics
approved these changes
Sep 4, 2020
|
Thanks @electriclilies @mbrookhart |
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
* frontend and start of cpp impl * upsampling3d typerel and makefunc * impl upsampling3d dynamic to static pass * passes test_dyn_upsampling3d_infer_type_const * fix bugs and improve doc for resize and upsampling * code cleanup * make tests more complex * code cleanup, fix test_dyn_upsampling3d_run * fix typo * ci not working
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
* frontend and start of cpp impl * upsampling3d typerel and makefunc * impl upsampling3d dynamic to static pass * passes test_dyn_upsampling3d_infer_type_const * fix bugs and improve doc for resize and upsampling * code cleanup * make tests more complex * code cleanup, fix test_dyn_upsampling3d_run * fix typo * ci not working
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
* frontend and start of cpp impl * upsampling3d typerel and makefunc * impl upsampling3d dynamic to static pass * passes test_dyn_upsampling3d_infer_type_const * fix bugs and improve doc for resize and upsampling * code cleanup * make tests more complex * code cleanup, fix test_dyn_upsampling3d_run * fix typo * ci not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the dynamic version of the UpSampling3D relay op. After this is merged, we will be able to remove the final infer_value calls from the onnx importer, allowing us to import truly dynamic onnx graphs into relay. I also cleaned up some documentation and tests for upsampling and resize
It is very similar to the dynamic UpSampling op (see #6273).
@mbrookhart @zhiics @icemelon9 please take a look