-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Add cmake options into libinfo #6286
[Build] Add cmake options into libinfo #6286
Conversation
This may be out of scope. For example, USE_LLVM=llvm-config provides the command (or a path) used to build with LLVM, but for reproducible purpose, LLVM=9.0 is way more useful. Since now every flag is explicitly specified in libinfo, is that possible to customize the displayed information of some flags to make them more useful? |
Hey @comaniac, I think you proposed two improvements
|
Hey thanks for the change. I agree with your methodology that we could customize the libinfo to deliver whatever we want. Apparently, it's impractical to parse camel.config and we have to manually setup the libinfo. With this statement, we should be able to have more flexibility in libinfo. For example, we even don't need USE_LLVM, USE_CUDA corresponding to cmake flags, but just need LLVM_VERSION, CUDA_VERSION. I think it's worthwhile to have an RFC discussing the libinfo contents (or we could refer to a previous RFC about benchmarking guidelines). However, this PR is a good start and shouldn't be blocked by such topics at least for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@comaniac I agree. It would be helpful if we have a forum thread discussing what should be included in the libinfo. A potentially issue is that I might not have all the devices required to verify correctness, for example, I don't have an ARM device at hand...Therefore, help from you guys and the community would be much appreciated! |
* [Build] Add cmake options into libinfo * Address comments from @tqchen * Add LLVM version to libinfo
* [Build] Add cmake options into libinfo * Address comments from @tqchen * Add LLVM version to libinfo
* [Build] Add cmake options into libinfo * Address comments from @tqchen * Add LLVM version to libinfo
* [Build] Add cmake options into libinfo * Address comments from @tqchen * Add LLVM version to libinfo
* [Build] Add cmake options into libinfo * Address comments from @tqchen * Add LLVM version to libinfo
To follow up with #6280, I added cmake options into libinfo, then if we execute the following command, we will have the full build info:
CC: @jroesch @jroesch @tqchen