-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoTVM][BugFix] Fix autotvm on the conv2d_nchw_winograd.mali operator #6130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comaniac
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kevinthesun
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…or (apache#6130) * [AutoTVM] Fix conv2d_nchw_winograd.mali * Fix pylint error Co-authored-by: Yanming Wang <[email protected]>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…or (apache#6130) * [AutoTVM] Fix conv2d_nchw_winograd.mali * Fix pylint error Co-authored-by: Yanming Wang <[email protected]>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…or (apache#6130) * [AutoTVM] Fix conv2d_nchw_winograd.mali * Fix pylint error Co-authored-by: Yanming Wang <[email protected]>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
…or (apache#6130) * [AutoTVM] Fix conv2d_nchw_winograd.mali * Fix pylint error Co-authored-by: Yanming Wang <[email protected]>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
…or (apache#6130) * [AutoTVM] Fix conv2d_nchw_winograd.mali * Fix pylint error Co-authored-by: Yanming Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs related to autotvm on the
conv2d_nchw_winograd.mali
operator.kvshape
autotvm.task.task.TaskTemplate.get_inputs
Due to the hack term here, both tensor
output
and tensorY
point to the same tensorM
, which causes tensorM
to be added in the queue twice. Using a hash set can remove duplicate nodes when performing level order traversal. @comaniac @kevinthesun @merrymercy