-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TVMC - a command line driver for TVM (Part 1) #6112
Conversation
If possible, I'll be presenting a live demo today on the "Online Compiler Chat". |
Thanks for the PR! Since CLI itself serves as an infra, it would be better to break this PR to a series of PRs like the following:
In this way, people can focus on the overall CLI infra in the first PR. Once everyone is happy with it, the rest PRs would have a much clearer scope. For example, "CLI -- compile" would attract people who are familiar with compilation flow. In this way, we can expect the following advantages:
|
Sure @comaniac, will do. |
The command name |
This is open for discussion - for the moment I'm keeping the original name of the work |
@comaniac here is a new version of this patch with only the minimal code to enable the command line. Follow up patches, that I will send after this, will deal with So, here is a checklist:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring! This is now much clearer.
On the other hand, since you also removed all subparsers from this PR, it's hard to imagine the subparser registration mechanism. I'd suggest adding one subparser that does nothing as a placeholder to illustrate the file organization, registration mechanism, and required fields. Otherwise, people might have the similar question as the one I left below.
* Introduce a command line driver to compile, run and tune models, using TVM graph runtime * Include tvmc tests and integrate tvmc with linting, testing and CI * RFC: https://discuss.tvm.ai/t/rfc-a-tvm-command-line-interface/5165 Co-authored-by: Marcus Shawcroft <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Dmitriy Smirnov <[email protected]> Co-authored-by: Luke Hutton <[email protected]> Co-authored-by: Giuseppe Rossini <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Elen Kalda <[email protected]> Co-authored-by: Ramana Radhakrishnan <[email protected]> Co-authored-by: Jeremy Johnson <[email protected]> Co-authored-by: Ina Dobreva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jroesch @yzhliu @icemelon9 @junrushao1994 |
* Introduce a command line driver to compile, run and tune models, using TVM graph runtime * Include tvmc tests and integrate tvmc with linting, testing and CI * RFC: https://discuss.tvm.ai/t/rfc-a-tvm-command-line-interface/5165 Co-authored-by: Marcus Shawcroft <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Dmitriy Smirnov <[email protected]> Co-authored-by: Luke Hutton <[email protected]> Co-authored-by: Giuseppe Rossini <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Elen Kalda <[email protected]> Co-authored-by: Ramana Radhakrishnan <[email protected]> Co-authored-by: Jeremy Johnson <[email protected]> Co-authored-by: Ina Dobreva <[email protected]> Co-authored-by: Marcus Shawcroft <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Dmitriy Smirnov <[email protected]> Co-authored-by: Luke Hutton <[email protected]> Co-authored-by: Giuseppe Rossini <[email protected]> Co-authored-by: Elen Kalda <[email protected]> Co-authored-by: Ramana Radhakrishnan <[email protected]> Co-authored-by: Jeremy Johnson <[email protected]> Co-authored-by: Ina Dobreva <[email protected]>
* Introduce a command line driver to compile, run and tune models, using TVM graph runtime * Include tvmc tests and integrate tvmc with linting, testing and CI * RFC: https://discuss.tvm.ai/t/rfc-a-tvm-command-line-interface/5165 Co-authored-by: Marcus Shawcroft <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Dmitriy Smirnov <[email protected]> Co-authored-by: Luke Hutton <[email protected]> Co-authored-by: Giuseppe Rossini <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Elen Kalda <[email protected]> Co-authored-by: Ramana Radhakrishnan <[email protected]> Co-authored-by: Jeremy Johnson <[email protected]> Co-authored-by: Ina Dobreva <[email protected]> Co-authored-by: Marcus Shawcroft <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Dmitriy Smirnov <[email protected]> Co-authored-by: Luke Hutton <[email protected]> Co-authored-by: Giuseppe Rossini <[email protected]> Co-authored-by: Elen Kalda <[email protected]> Co-authored-by: Ramana Radhakrishnan <[email protected]> Co-authored-by: Jeremy Johnson <[email protected]> Co-authored-by: Ina Dobreva <[email protected]>
* Introduce a command line driver to compile, run and tune models, using TVM graph runtime * Include tvmc tests and integrate tvmc with linting, testing and CI * RFC: https://discuss.tvm.ai/t/rfc-a-tvm-command-line-interface/5165 Co-authored-by: Marcus Shawcroft <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Dmitriy Smirnov <[email protected]> Co-authored-by: Luke Hutton <[email protected]> Co-authored-by: Giuseppe Rossini <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Elen Kalda <[email protected]> Co-authored-by: Ramana Radhakrishnan <[email protected]> Co-authored-by: Jeremy Johnson <[email protected]> Co-authored-by: Ina Dobreva <[email protected]> Co-authored-by: Marcus Shawcroft <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Dmitriy Smirnov <[email protected]> Co-authored-by: Luke Hutton <[email protected]> Co-authored-by: Giuseppe Rossini <[email protected]> Co-authored-by: Elen Kalda <[email protected]> Co-authored-by: Ramana Radhakrishnan <[email protected]> Co-authored-by: Jeremy Johnson <[email protected]> Co-authored-by: Ina Dobreva <[email protected]>
* Introduce a command line driver to compile, run and tune models, using TVM graph runtime * Include tvmc tests and integrate tvmc with linting, testing and CI * RFC: https://discuss.tvm.ai/t/rfc-a-tvm-command-line-interface/5165 Co-authored-by: Marcus Shawcroft <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Dmitriy Smirnov <[email protected]> Co-authored-by: Luke Hutton <[email protected]> Co-authored-by: Giuseppe Rossini <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Elen Kalda <[email protected]> Co-authored-by: Ramana Radhakrishnan <[email protected]> Co-authored-by: Jeremy Johnson <[email protected]> Co-authored-by: Ina Dobreva <[email protected]> Co-authored-by: Marcus Shawcroft <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Dmitriy Smirnov <[email protected]> Co-authored-by: Luke Hutton <[email protected]> Co-authored-by: Giuseppe Rossini <[email protected]> Co-authored-by: Elen Kalda <[email protected]> Co-authored-by: Ramana Radhakrishnan <[email protected]> Co-authored-by: Jeremy Johnson <[email protected]> Co-authored-by: Ina Dobreva <[email protected]>
* Introduce a command line driver to compile, run and tune models, using TVM graph runtime * Include tvmc tests and integrate tvmc with linting, testing and CI * RFC: https://discuss.tvm.ai/t/rfc-a-tvm-command-line-interface/5165 Co-authored-by: Marcus Shawcroft <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Dmitriy Smirnov <[email protected]> Co-authored-by: Luke Hutton <[email protected]> Co-authored-by: Giuseppe Rossini <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Elen Kalda <[email protected]> Co-authored-by: Ramana Radhakrishnan <[email protected]> Co-authored-by: Jeremy Johnson <[email protected]> Co-authored-by: Ina Dobreva <[email protected]> Co-authored-by: Marcus Shawcroft <[email protected]> Co-authored-by: Matthew Barrett <[email protected]> Co-authored-by: Dmitriy Smirnov <[email protected]> Co-authored-by: Luke Hutton <[email protected]> Co-authored-by: Giuseppe Rossini <[email protected]> Co-authored-by: Elen Kalda <[email protected]> Co-authored-by: Ramana Radhakrishnan <[email protected]> Co-authored-by: Jeremy Johnson <[email protected]> Co-authored-by: Ina Dobreva <[email protected]>
TVMC - a command line driver for TVM