Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVM/CPU] Terminate basic block after "ret" instruction #6036

Merged
merged 3 commits into from
Jul 10, 2020
Merged

[LLVM/CPU] Terminate basic block after "ret" instruction #6036

merged 3 commits into from
Jul 10, 2020

Conversation

kparzysz-quic
Copy link
Contributor

ret is a terminator in LLVM IR and there should be no instructions in the basic block following it. When generating a ret, end the current block and start a new one.

Krzysztof Parzyszek added 3 commits July 10, 2020 10:19
"Ret" is a terminator in LLVM IR and there should be no instructions
in the basic block following it. When generating a "ret", end the
current block and start a new one.
@tqchen tqchen merged commit c9c77c6 into apache:master Jul 10, 2020
@tqchen
Copy link
Member

tqchen commented Jul 10, 2020

Thanks @kparzysz-quic !

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jul 14, 2020
* [LLVM/CPU] Terminate basic block after "ret" instruction

"Ret" is a terminator in LLVM IR and there should be no instructions
in the basic block following it. When generating a "ret", end the
current block and start a new one.
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jul 14, 2020
* [LLVM/CPU] Terminate basic block after "ret" instruction

"Ret" is a terminator in LLVM IR and there should be no instructions
in the basic block following it. When generating a "ret", end the
current block and start a new one.
@kparzysz-quic kparzysz-quic deleted the cpu-ret branch October 23, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants